Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82938

Consistent table sorting icons in report builder editor

XMLWordPrintable

      The table sorting icons ('t/sort_asc' and 't/sort_desc') have been improved in MDL-82497, as shown below:

      The report builder editor Sorting section is using a different icon - which is now exacerbated since the above change:

      We should make them consistent, so that the editor uses the same icons as those use by report tables. Also note the language string is confusing because it's attempting to indicate the state of the sorting after clicking the button, whereas it looks like it's indicating the current state of the sorting

      We should use language similar to this to make it clearer as to the sorting current state and the behaviour of the button:

      +$string['columnsortdirectionasc'] = 'Change initial sorting for column \'{$a}\' to ascending';
      +$string['columnsortdirectiondesc'] = 'Change initial sorting for column \'{$a}\' to descending';
      

        1. (1) 5 Passed -- (Main)MDL-82938.png
          (1) 5 Passed -- (Main)MDL-82938.png
          149 kB
        2. Editor.png
          Editor.png
          12 kB
        3. Report.png
          Report.png
          23 kB

            pholden Paul Holden
            pholden Paul Holden
            Carlos Castillo Carlos Castillo
            David Carrillo David Carrillo
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 5 minutes
                1h 5m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.