Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83005

Doubled-up user tour content when using 'Show with backdrop'

XMLWordPrintable

    • MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
    • MOODLE_404_STABLE, MOODLE_405_STABLE
    • MDL-83005-404
    • MDL-83005-405
    • MDL-83005-main
    • Hide

      IMPORTANT

      Perform these tests in Boost and in Classic (where possible).

      Default tours

      1. Go to a course's grades page
      2. If necessary, click the ? icon and reset the user tour for this page.
      3. CONFIRM the default tour displays correctly
      4. Go to the courses page
      5. If necessary, click the ? icon and reset the user tour for this page.
      6. CONFIRM the default tour displays correctly
      7. Go to the Dashboard
      8. If necessary, click the ? icon and reset the user tour for this page.
      9. CONFIRM the default tour displays correctly

      CSS selector

      1. Go to site admin -> appearance -> user tours
      2. Create a new tour
      3. Give the tour a name
      4. Set 'Apply to URL match' to /course/view.php%
      5. Set 'Show with backdrop' to Yes
      6. Save changes
      7. Disable the other tours using the /course/view.php%  and only enable your new tour
      8. Click on the 'View' icon for your tour to create some steps
      9. Click 'New step'
      10. Set the 'Target type' to Selector
      11. Set 'CSS selector' to .course-content
      12. Set 'Title' to anything
      13. Set 'Content' to anything
      14. Save changes
      15. Create a course and view it
      16. CONFIRM the user tour displays correctly

      Block (offscreen)

      1. Go to site admin -> appearance -> user tours
      2. Create a new tour
      3. Give the tour a name
      4. Set 'Apply to URL match' to FRONTPAGE_MY
      5. Set 'Show with backdrop' to Yes
      6. Save changes
      7. Disable the other tours using the FRONTPAGE_MY and only enable your new tour
      8. Click on the 'View' icon for your tour to create some steps
      9. Click 'New step'
      10. Set the 'Target type' to Block
      11. Set the block to Timeline
      12. Set 'Title' to anything
      13. Set 'Content' to anything
      14. Save changes
      15. Go to the dashboard.
      16. Go into edit mode and position the timeline block below the calendar (we want to make the timeline block off screen).
      17. Click the ? icon and reset the user tour for this page.
      18. CONFIRM the user tour animates the scrolling to the location and displays the tour content properly.

      Middle of page

      1. Go to site admin -> appearance -> user tours
      2. Create a new tour
      3. Give the tour a name
      4. Set 'Apply to URL match' to FRONTPAGE_MY
      5. Set 'Show with backdrop' to Yes
      6. Save changes
      7. Disable the other tours using the FRONTPAGE_MY and only enable your new tour
      8. Click on the 'View' icon for your tour to create some steps
      9. Click 'New step'
      10. Set the 'Target type' to Display in middle of page
      11. Set 'Title' to anything
      12. Set 'Content' to anything
      13. Save changes
      14. Go to the dashboard.
      15. Click the ? icon and reset the user tour for this page.
      16. CONFIRM the user tour displays correctly
      Show
      IMPORTANT Perform these tests in Boost and in Classic (where possible). Default tours Go to a course's grades page If necessary, click the ? icon and reset the user tour for this page. CONFIRM the default tour displays correctly Go to the courses page If necessary, click the ? icon and reset the user tour for this page. CONFIRM the default tour displays correctly Go to the Dashboard If necessary, click the ? icon and reset the user tour for this page. CONFIRM the default tour displays correctly CSS selector Go to site admin -> appearance -> user tours Create a new tour Give the tour a name Set 'Apply to URL match' to  /course/view.php% Set 'Show with backdrop' to  Yes Save changes Disable the other tours using the  /course/view.php%   and only enable your new tour Click on the 'View' icon for your tour to create some steps Click 'New step' Set the 'Target type' to  Selector Set 'CSS selector' to  .course-content Set 'Title' to anything Set 'Content' to anything Save changes Create a course and view it CONFIRM the user tour displays correctly Block (offscreen) Go to site admin -> appearance -> user tours Create a new tour Give the tour a name Set 'Apply to URL match' to FRONTPAGE_MY Set 'Show with backdrop' to  Yes Save changes Disable the other tours using the FRONTPAGE_MY and only enable your new tour Click on the 'View' icon for your tour to create some steps Click 'New step' Set the 'Target type' to  Block Set the block to Timeline Set 'Title' to anything Set 'Content' to anything Save changes Go to the dashboard. Go into edit mode and position the timeline block below the calendar (we want to make the timeline block off screen). Click the ? icon and reset the user tour for this page. CONFIRM the user tour animates the scrolling to the location and displays the tour content properly. Middle of page Go to  site admin -> appearance -> user tours Create a new tour Give the tour a name Set 'Apply to URL match' to  FRONTPAGE_MY Set 'Show with backdrop' to  Yes Save changes Disable the other tours using the  FRONTPAGE_MY  and only enable your new tour Click on the 'View' icon for your tour to create some steps Click 'New step' Set the 'Target type' to  Display in middle of page Set 'Title' to anything Set 'Content' to anything Save changes Go to the dashboard. Click the ? icon and reset the user tour for this page. CONFIRM  the user tour displays correctly
    • Hide

      Fails against automated checks.

      Checked MDL-83005 using repository: https://github.com/davewoloszyn/moodle.git

      Should these errors be fixed?

      Built on: Mon 25 Nov 2024 04:39:14 AM UTC

      Show
      Fails against automated checks. Checked MDL-83005 using repository: https://github.com/davewoloszyn/moodle.git MOODLE_404_STABLE (1 errors / 1 warnings) [branch: MDL-83005-404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (1/1) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_405_STABLE (1 errors / 1 warnings) [branch: MDL-83005-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (1/1) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (1 errors / 1 warnings) [branch: MDL-83005-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (1/1) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Mon 25 Nov 2024 04:39:14 AM UTC
    • Hide

      Launching automatic jobs for branch MDL-83005-404

      Launching automatic jobs for branch MDL-83005-405

      Launching automatic jobs for branch MDL-83005-main

      Built on: Mon Nov 25 04:25:19 AM UTC 2024

      Show
      Launching automatic jobs for branch MDL-83005 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17503/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59629/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59630/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83005 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17504/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59631/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59632/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83005 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17505/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59633/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59634/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59635/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59636/ App tests (stable app version) Built on: Mon Nov 25 04:25:19 AM UTC 2024
    • 6
    • Team Hedgehog 2024 Sprint 3.2, Team Hedgehog 2024 Sprint 3.3, Team Hedgehog 2024 Review 4, Team Hedgehog 2024 Sprint 4.1, Team Hedgehog 2024 Sprint 4.2, Team Hedgehog 2024 Sprint 4.3

      Discovered while testing MDLQA-19203.

      There is a doubling-up of content when the backdrop highlights the user tour content. I could only reproduce this on Moodle 4.4 and 4.5. It didn't seem to be a problem before this.

      Step to reproduce:

      1. Go to site admin -> appearance -> user tours
      2. Create a new tour
      3. Give the tour a name
      4. Set 'Apply to URL match' to /course/view.php%
      5. Set 'Show with backdrop' to Yes
      6. Save changes
      7. Disable the other tours using the /course/view.php%  and only enable your new tour
      8. Click on the 'View' icon for your tour to create some steps
      9. Click 'New step'
      10. Set the 'Target type' to Selector
      11. Set 'CSS selector' to .course-content
      12. Set 'Title' to anything
      13. Set 'Content' to anything
      14. Save changes
      15. Create a course and view it
      16. OBSERVE the doubled-up content

       

        1. blocks-issue.png
          blocks-issue.png
          29 kB
        2. cloning-issue.png
          cloning-issue.png
          58 kB
        3. correction to anchor.png
          correction to anchor.png
          186 kB
        4. course-content selector bug.png
          course-content selector bug.png
          123 kB
        5. expected.png
          expected.png
          111 kB
        6. happens-in-4-3-too.mov
          11.56 MB
        7. image-2024-09-12-10-29-40-583.png
          image-2024-09-12-10-29-40-583.png
          181 kB
        8. image-2024-11-04-10-54-15-842.png
          image-2024-11-04-10-54-15-842.png
          684 kB
        9. image-2024-11-04-10-54-35-545.png
          image-2024-11-04-10-54-35-545.png
          274 kB
        10. misalignment.mov
          1.36 MB
        11. Screen Recording 2024-12-03 at 9.55.09 pm.mov
          18.73 MB
        12. unexpected.png
          unexpected.png
          108 kB
        13. without-patch-using-selectors.png
          without-patch-using-selectors.png
          61 kB
        14. z-index-issue.png
          z-index-issue.png
          77 kB

            david.woloszyn@moodle.com David Woloszyn
            david.woloszyn@moodle.com David Woloszyn
            Huong Nguyen Huong Nguyen
            Shamim Rezaie Shamim Rezaie
            Glyn (Mathew) May Glyn (Mathew) May
            Votes:
            2 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 week, 3 hours, 54 minutes
                1w 3h 54m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.