Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.4, 4.5
Component/s: Blocks
Labels:
- CatalystIT
- ci
- partner

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/catalyst/moodle
Pull 4.3 Branch:
MDL-83044-403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...catalyst:moodle:MDL-83044-403
Pull 4.4 Branch:
MDL-83044-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...catalyst:moodle:MDL-83044-404
Pull 4.5 Branch:
MDL-83044-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...catalyst:moodle:MDL-83044-405
Pull Main Branch:
MDL-83044
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...catalyst:moodle:MDL-83044
Testing Instructions:
Testing:
- Manual testing should not be required but if you wish to do so, follow the steps below to reproduce the issue.
- Verify existing tests pass.
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-83044 using repository: https://github.com/catalyst/moodle

MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-83044-403 | CI Job]

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83044-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83044-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83044 | CI Job]

_{More information about this report}

Built on: Mon 09 Dec 2024 09:59:23 PM UTC
Show
Code verified against automated checks. Checked MDL-83044 using repository: https://github.com/catalyst/moodle MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-83044-403 | CI Job ] MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83044-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83044-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83044 | CI Job ] More information about this report Built on: Mon 09 Dec 2024 09:59:23 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch MDL-83044-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17669/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60194/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60195/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-83044-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17670/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60196/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60197/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-83044-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17671/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60198/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60199/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-83044

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17672/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60200/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60201/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60202/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60203/ App tests (stable app version)

Built on: Mon Dec 9 10:25:23 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83044 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17669/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60194/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60195/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83044 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17670/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60196/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60197/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83044 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17671/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60198/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60199/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83044 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17672/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60200/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60201/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60202/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60203/ App tests (stable app version) Built on: Mon Dec 9 10:25:23 PM UTC 2024

The call to add_block_at_end_of_default_region can return null, but if it does, an exception is thrown (block_not_on_page_exception) when find_instance is called.

This can happen if a plugin overrides add_block_at_end_of_default_region and intentionally returns null in order to prevent a user adding a block:

https://moodle.org/plugins/tool_blocksmanager

https://github.com/moodle/moodle/blob/main/blocks/edit_form.php#L434-L452

Steps to reproduce:

Setup a Moodle site
Install the tool_blocksmanager plugin
- Open the site root directory in your terminal
- git clone -b MOODLE_404_STABLE git@github.com:catalyst/moodle_tool_blocksmanager.git admin/tool/blocksmanager
Navigate to /admin/tool/blocksmanager/region.php
Click Add new locked region
- Set region to side-pre
- Select all categories (e.g. Category 1)
- Set Allow to add? to No
- Save changes
Navigate to a course in one of the selected categories
Log in as a teacher (setting role to teacher won't work)
Attempt to add a block (e.g. Text block)
Verify you see an exception message
Apply the MDL-83044 patch
Attempt to add a block
Verify you see a red notice banner instead

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

issue_record.webm
5.56 MB
16/Sep/24 11:01 PM
issue.png
112 kB
16/Sep/24 11:01 PM
Screencast from 29-10-24.webm
5.27 MB
29/Oct/24 10:27 AM
Screenshot from 2024-09-08 21-27-00.png
139 kB
08/Sep/24 9:40 PM

has a non-specific relationship to

MDL-83098 Add type declarations to class block_manager

Closed

has been marked as being related by

MDL-74465 Display block configuration form in a popup

Closed

Assignee:: Alexander Van der Bellen

Reporter:: Alexander Van der Bellen

Peer reviewer:: Dmitrii Metelkin

Participants:: Alexander Van der Bellen, CiBoT, Dmitrii Metelkin, Safat Shahin

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 08/Sep/24 9:38 PM

Updated:: 10/Dec/24 9:13 AM

Estimated:

Remaining:

Logged:

30m

Details

Testing:

Description

Steps to reproduce:

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify