Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 4.1.14, 4.3.8, 4.4.4
Affects Version/s: 4.4.3
Component/s: Accessibility, Themes
Labels:
- CatalystIT
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 4.1 Branch:
~~MDL-83047~~-401
Pull 4.1 Diff URL:
https://github.com/junpataleta/moodle/compare/69beec3d2a...MDL-83047-401
Pull 4.3 Branch:
~~MDL-83047~~-403
Pull 4.3 Diff URL:
https://github.com/junpataleta/moodle/compare/7f6d05ad04...MDL-83047-403
Pull 4.4 Branch:
~~MDL-83047~~-404
Pull 4.4 Diff URL:
https://github.com/junpataleta/moodle/compare/9ecb8de2bb...MDL-83047-404
Pull Main Branch:
~~MDL-83047~~-main
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/1938c438ea...MDL-83047-main
Testing Instructions:
Hide

Test the headings in maintenance and secure layouts

Repeat the test in ~~MDL-82677~~ in Boost and Classic.

Test the headings in other themes

Install the Boost Magnific theme.

Use this theme

Go to an activity, the dashboard, or the course homepage.

Confirm that the headings don't have a white background. (The default background colour of the theme is quite light, but the white background on the headings will be noticeable without the patch)
Show
Test the headings in maintenance and secure layouts Repeat the test in MDL-82677 in Boost and Classic. Test the headings in other themes Install the Boost Magnific theme . Use this theme Go to an activity, the dashboard, or the course homepage. Confirm that the headings don't have a white background. (The default background colour of the theme is quite light, but the white background on the headings will be noticeable without the patch)

Paraphrased from this comment.

[The change introduced by MDL-82677] will break 100% of themes where the page background colour doesn't match the header colour and takes zero consideration of the actual colour of the header text, making the contrast far worse in many cases where default text colours are used. This change is also far reaching and doesn't just address the problematic page but appears to affect every page in the system. Any change should be restricted to the upgrade pages only.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83047.png
5.36 MB
10/Sep/24 2:39 PM

is a regression caused by

MDL-82677 Upgrade screen can have poor contrast when a background image is set

Closed

Assignee:: Jun Pataleta

Reporter:: cameron1729

Peer reviewer:: cameron1729

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: Brett Dalton, cameron1729, CiBoT, Huong Nguyen, Jun Pataleta, Przemek Kaszubski, Ron Carl Alfon Yu

Votes:: 3 Vote for this issue

Watchers:: 11 Start watching this issue

Created:: 09/Sep/24 11:14 AM

Updated:: 01/Oct/24 6:35 PM

Resolved:: 10/Sep/24 11:08 PM

Estimated:

Not Specified

Remaining:

Logged:

5h 39m

Details

Test the headings in maintenance and secure layouts

Test the headings in other themes

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify