Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83081

Remove the "label | dndmedia" setting

XMLWordPrintable

    • MOODLE_500_STABLE
    • MOODLE_501_STABLE
    • MDL-83081-main
    • Hide

      Migration test

      1. Install Moodle without the patch
      2. Login as admin and go to "Site administration -> plugins -> Activity modules -> Text and media area" 
      3. Change the value of the "Media drag and drop" setting and save changes.
        1. Check that the following query in the database returns one result: SELECT * FROM mdl_config_plugins WHERE name = 'dndmedia' AND plugin = 'label'
      4. Apply the patch
      5. Log in as admin and proceed to the upgrade
        1. Check that the following query in the database does NOT return any result: SELECT * FROM mdl_config_plugins WHERE name = 'dndmedia' AND plugin = 'label'

      Drag and drop test

      1. Create a course
      2. Drag an image file from a file browser to a section
      3. Check that a modal appears with at least one option "Add media to course page".
      Show
      Migration test Install Moodle without the patch Login as admin and go to "Site administration -> plugins -> Activity modules -> Text and media area"  Change the value of the "Media drag and drop" setting and save changes. Check that the following query in the database returns one result: SELECT * FROM mdl_config_plugins WHERE name = 'dndmedia' AND plugin = 'label' Apply the patch Log in as admin and proceed to the upgrade Check that the following query in the database does NOT return any result: SELECT * FROM mdl_config_plugins WHERE name = 'dndmedia' AND plugin = 'label' Drag and drop test Create a course Drag an image file from a file browser to a section Check that a modal appears with at least one option "Add media to course page".
    • Hide

      Code verified against automated checks.

      Checked MDL-83081 using repository: https://github.com/ferranrecio/moodle.git

      More information about this report

      Built on: Mon May 12 14:26:34 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-83081 using repository: https://github.com/ferranrecio/moodle.git main (0 errors / 0 warnings) [branch: MDL-83081-main | CI Job ] More information about this report Built on: Mon May 12 14:26:34 UTC 2025
    • Hide

      Launching automatic jobs for branch MDL-83081-main

      Built on: Mon Apr 14 10:26:04 UTC 2025

      Show
      Launching automatic jobs for branch MDL-83081 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19007/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65019/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65020/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65021/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65022/ App tests (stable app version) Built on: Mon Apr 14 10:26:04 UTC 2025
    • 1
    • HQ 2025 Sprint I1.4 Moppies

      Since 12 years ago, mod_label has been able to handle images dragged directly onto the course page. For some reason, lost in time, a new admin setting is created to disable this behaviour.

      When this was implemented, dragging files into the browser was probably not stable enough and used third-party libraries, but nowadays, the course editor uses the browser's standard API. It is unclear why an admin might disable dragging media as a label while keeping any other drag&dorp enabled. Even if the cost of maintaining this setting is low, it creates unnecessary edge cases and complexity for scenarios that do not seem based on reality.

      This issue aims to make media drag and drop enable always in mod_label and remove it as an optional setting.

      For the record, the original commit specifies the code MDL-32456. However, this issue is not about mod_albel, and the original branches are removed, so there is no way to know why this setting was created.

        1. MDL-83081.png
          MDL-83081.png
          599 kB

            tusefomal Ferran Recio
            tusefomal Ferran Recio
            Carlos Escobedo Carlos Escobedo
            Amaia Anabitarte Amaia Anabitarte
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 43 minutes
                1h 43m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.