Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83109

Replace fa-times with fa-xmark

XMLWordPrintable

    • MOODLE_405_STABLE
    • MOODLE_405_STABLE
    • MDL-83109-main
    • Hide

      Setup

      1. Download the attached MDL-83109.feature.
      2. Run the following command to create a course: 

        php admin/tool/generator/cli/runtestscenario.php --feature="absolute/path/to/file.feature"

        It might fail while creating the users if they already exist in your local instance. If that's the case, this error can be ignored.

      1. Login as admin.
      2. Go to the course "MDL-83109".
      3. Access "Assignment failed" and grade student 1 with 10 (or any other failing grade).

       

      Testing instructions

      1. Login as student 1 (s1).
      2. Go to the course "MDL-83109".
      3. Mark "Assignment manual " as Done.
      4. In the course index:
        1. Check Assignment failed has fa-x-mark icon
        2. Check Assignment manual has fa-circle.
        3. Check Assignment 3 has fa-regular fa-circle.
        4. Inspect the styles and check these icons are displayed with font-size set to 10px.
      Show
      Setup Download the attached MDL-83109.feature . Run the following command to create a course:  php admin/tool/generator/cli/runtestscenario.php --feature="absolute/path/to/file.feature" It might fail while creating the users if they already exist in your local instance. If that's the case, this error can be ignored. Login as admin. Go to the course " MDL-83109 ". Access "Assignment failed" and grade student 1 with 10 (or any other failing grade).   Testing instructions Login as student 1 (s1). Go to the course " MDL-83109 ". Mark "Assignment manual " as Done. In the course index: Check Assignment failed has fa-x-mark icon Check Assignment manual has fa-circle. Check Assignment 3 has fa-regular fa-circle. Inspect the styles and check these icons are displayed with font-size set to 10px.
    • 1
    • HQ 2024 Sprint I3.2 Moppies

      In FA6, a few icons were renamed. Although the legacy library is installed, in MDL-77537 they have been upgraded to use the new name but one of them was missed: fa-times was renamed to fa-xmark.

      Apart from updating this icon, the UX team also asked to decrease the font-size for the course-index icons from 12px to 10px (while they were working on the custom icons).

            sarjona Sara Arjona (@sarjona)
            sarjona Sara Arjona (@sarjona)
            Carlos Escobedo Carlos Escobedo
            Amaia Anabitarte Amaia Anabitarte
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 42 minutes
                1h 42m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.