Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83150

Badge "Expired" overlay on user profile page doesn't display correctly

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not a bug
    • Icon: Minor Minor
    • None
    • 4.4 regressions, 4.4.3
    • Badges
    • MOODLE_404_STABLE
    • Hide
      1. Log in as admin
      2. Create a user
      3. Navigate to Badges > Add a new badge in site administration
        • Fill in required fields
        • Set Expiry date to "1 January 2025"
      4. Add Manual issue by role badge criteria
        • Select Manager
      5. Press Enable access to enable the badge
      6. Navigate to badge Recipients page
      7. Award badge to test user
      8. Open your DB editor, run the following query to find the badge you just awarded: 

        SELECT * FROM m_badge_issued;

      9. Edit the "dateexpire" field of the row to the following value: 1704067200
      10. Navigate to profile of test user
      11. Confirm the awarded badge image as the "Expired" image overlay visible across it
      Show
      Log in as admin Create a user Navigate to Badges > Add a new badge in site administration Fill in required fields Set Expiry date to "1 January 2025" Add Manual issue by role badge criteria Select Manager Press Enable access to enable the badge Navigate to badge Recipients page Award badge to test user Open your DB editor, run the following query to find the badge you just awarded: SELECT * FROM m_badge_issued; Edit the "dateexpire" field of the row to the following value: 1704067200 Navigate to profile of test user Confirm the awarded badge image as the "Expired" image overlay visible across it

      The "Expired" overlay that should appear over expired badges on the user profile page is currently broken in main & 4.4 due to two separate regressions:

      Overlay size

      Despite the "Expired" image being present in the DOM, this change from MDL-78284 (from 4.4) means it's practically hidden because it's height/width have an upper boundary of 24px. It should be 100px

      Overlay image

      When updating FA6 images in MDL-82497 (4.5) the original "Expired" image has been replaced with an indeterminate orange circle, so when the previous size issue is addressed (above) then it looks like this:

      I'd suggest for now this icon change should be reverted given there doesn't appear to be any discussion that this was a deliberate change

      Semi-related to/appears to have happened before, at MDL-67974

        1. 404-size.png
          404-size.png
          154 kB
        2. main-icon.png
          main-icon.png
          17 kB

            Unassigned Unassigned
            pholden Paul Holden
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.