Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.4, 4.5
Component/s: Glossary
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.4 Branch:
~~MDL-83152~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83152-404?w=1
Pull 4.5 Branch:
~~MDL-83152~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83152-405?w=1
Pull Main Branch:
~~MDL-83152~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83152?w=1
Testing Instructions:
Hide

Log in as admin

Create a user

Create a course

Enrol user in course as student

Add Glossary activity to course

Entries > Approved by default: No

Log out

Log in as test user

Navigate to course glossary

Add a couple of entries

Log out

Log in as admin

Navigate to course glossary

Press Pending approval (2)

Confirm you can sort the entries chronologically by update/creation date, both ascending and descending
Show
Log in as admin Create a user Create a course Enrol user in course as student Add Glossary activity to course Entries > Approved by default: No Log out Log in as test user Navigate to course glossary Add a couple of entries Log out Log in as admin Navigate to course glossary Press Pending approval (2) Confirm you can sort the entries chronologically by update/creation date, both ascending and descending
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83152~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83152-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83152-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83152 | CI Job]

_{More information about this report}

Built on: Fri Jan 17 10:38:56 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-83152 using repository: https://github.com/paulholden/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83152-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83152-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83152 | CI Job ] More information about this report Built on: Fri Jan 17 10:38:56 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83152~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17782/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60561/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60562/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83152~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17783/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60563/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60564/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83152~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17784/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60565/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60566/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60567/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60568/ App tests (stable app version)

Built on: Sun Dec 22 04:30:22 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83152 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17782/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60561/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60562/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83152 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17783/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60563/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60564/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83152 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17784/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60565/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60566/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60567/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60568/ App tests (stable app version) Built on: Sun Dec 22 04:30:22 PM UTC 2024

In Glossary, in pending approval view, the "By last update" and "By creation date" sorting order UI elements do not react.

TO REPRODUCE:
As teacher, add a glossary and set Entries: Approved by default to "no".
As student, add a glossary entry.
As teacher, view the glossary, switching to the "Pending approval (1)" tab.
Try to click "By last update" and "By creation date" to set the views and its ordering from desc to asc.

WHAT YOU EXPECT:
The asc/desc changes, the "By last update" or "By creation date" becomes bold.
WHAT ACTUALLY HAPPENS:
No asc/desc changes, "By creation date" stays bold no matter what.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83152_1.png
35 kB
30/Jan/25 7:37 PM
MDL-83152_2.png
35 kB
30/Jan/25 7:37 PM
MDL-83152.gif
525 kB
15/Sep/24 7:10 PM
MDL-83152 JS error.png
142 kB
30/Jan/25 11:01 AM

Discovered while testing

MDL-51119 Multilingual glossary entries showing up on the chosen Moodle UI/concept language corresponding combination only, allowing for extended multilinguality

Closed

duplicates

MDL-51823 Glossary approval screen ordering and special options are not working as expected

Closed

Assignee:: Paul Holden

Reporter:: Luca Bösch

Peer reviewer:: Luca Bösch

Integrator:: Glyn (Mathew) May

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Glyn (Mathew) May, Kim Jared Lucas, Luca Bösch, Paul Holden, Sara Arjona (@sarjona), Simey Lameze

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 15/Sep/24 7:02 PM

Updated:: 04/Feb/25 1:56 PM

Resolved:: 31/Jan/25 10:48 AM

Estimated:

Remaining:

Logged:

3h 18m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify