Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.3.8, 4.4.4
Affects Version/s: 4.5
Component/s: Course
Labels:
- CatalystIT
- ci
- partner
- regression
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Pull from Repository:
https://github.com/danmarsden/moodle.git
Pull 4.3 Branch:
m43-md83163
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...danmarsden:m43-md83163
Pull 4.4 Branch:
m44-md83163
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...danmarsden:m44-md83163
Pull Main Branch:
mdl83310
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...danmarsden:mdl83310
Testing Instructions:
Hide

Setup

Install a 3rd party course format plugin into the site - (any 3rd party format from the plugins directory will do)

If using MDK, you can use the "mdk plugin install" command. For example, to install the format_grid plugin run "mdk plugin install format_grid"

Test

Initialise PHPUnit and run the unit test:

vendor/bin/phpunit course/tests/courselib_test.php

Or if using MDK: "mdk phpunit -r -u course/tests/courselib_test.php"

Confirm the test is passing.
Show
Setup Install a 3rd party course format plugin into the site - (any 3rd party format from the plugins directory will do) If using MDK, you can use the "mdk plugin install" command. For example, to install the format_grid plugin run " mdk plugin install format_grid " Test Initialise PHPUnit and run the unit test: vendor /bin/phpunit course /tests/courselib_test .php Or if using MDK: " mdk phpunit -r -u course/tests/courselib_test.php " Confirm the test is passing.

The patch in ~~MDL-83163~~ has caused a regression in the unit tests when the codebase includes other 3rd party course formats.

Install any 3rd party course format (tiles is what I've used)

Run test_get_sorted_course_formats_installed_or_not unit test.

There was 1 failure:

1) core_course\courselib_test::test_get_sorted_course_formats_installed_or_not

Failed asserting that two arrays are equal.

--- Expected

+++ Actual

@@ @@

     1 => 'weeks'

     2 => 'singleactivity'

     3 => 'social'

+    4 => 'tiles'

/builds/elearning/local/moodle-local/course/tests/courselib_test.php:7519

I've spotted this in 4.5 but it's likely to be an issue on other branches too.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83310.png
174 kB
02/Oct/24 2:40 PM

is a regression caused by

MDL-83163 Fresh install fails if there are dependencies on format plugins

Closed

Assignee:: Dan Marsden

Reporter:: Dan Marsden

Peer reviewer:: Sam Marshall

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: Carlos Escobedo, CiBoT, Dan Marsden, Jun Pataleta, Ron Carl Alfon Yu, Sam Marshall

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 30/Sep/24 3:22 PM

Updated:: 04/Oct/24 11:10 PM

Resolved:: 04/Oct/24 11:10 PM

Estimated:

Remaining:

Logged:

1h 16m

Details

Setup

Test

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify