Hard to verify until other parts of the PHP 8.4 epic land. Please verify manually that all instances of fgetcsv() and fputcsv() have the correct value for $escape . Note: The following locations have not been updated as they pertain to third-party library code: lib/adodb lib/mlbackend

Fails against automated checks. Checked MDL-83335 using repository: https://github.com/andrewnicols/moodle.git main (2 errors / 1 warnings) [branch: MDL-83335-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (2/1) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Tue Jan 7 05:46:11 AM UTC 2025

Launching automatic jobs for branch MDL-83335 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17819/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60694/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60695/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60696/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60697/ App tests (stable app version) Built on: Tue Jan 7 06:25:14 AM UTC 2025