Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-83335

fgetcsv and fputcsv deprecate empty default for escape arg

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 5.0
    • General, Libraries
    • None
    • MOODLE_500_STABLE
    • MDL-83335-main
    • Hide

      Hard to verify until other parts of the PHP 8.4 epic land.

      Please verify manually that all instances of fgetcsv() and fputcsv() have the correct value for $escape.

      Note: The following locations have not been updated as they pertain to third-party library code:

      • lib/adodb
      • lib/mlbackend
      Show
      Hard to verify until other parts of the PHP 8.4 epic land. Please verify manually that all instances of fgetcsv() and fputcsv() have the correct value for $escape . Note: The following locations have not been updated as they pertain to third-party library code: lib/adodb lib/mlbackend

      https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_proprietary_csv_escaping_mechanism

      We need to specify it everywhere in core. This part is easy.

      There are a few affected libraries too:

      • phpml
      • adodb

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            David Woloszyn David Woloszyn
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 23 minutes
                1h 23m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.