Loading...

XML

Word

Printable

Type: Improvement
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 5.0
Component/s: General, Libraries
Labels:

Affected Branches:
MOODLE_500_STABLE
Epic Link:
Prepare Moodle for PHP 8.4
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull Main Branch:
MDL-83336-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/67f5ee3cec...MDL-83336-main?w=1
Testing Instructions:
Hide

Grep for xml_set_object():

git grep xml_set_object

Confirm there are no code usages

Grep for xml_set_.*_handler

git grep xml_set_.*_handler

Confirm that each code usage and ensure that the 2nd (and if present 3rd) parameter ar arrays and not just a string

NOTE: There may be usages in the following libraries:

adodb

phpxmlrpc

simplepie
Show
Grep for xml_set_object() : git grep xml_set_object Confirm there are no code usages Grep for xml_set_.*_handler git grep xml_set_.*_handler Confirm that each code usage and ensure that the 2nd (and if present 3rd) parameter ar arrays and not just a string NOTE: There may be usages in the following libraries: adodb phpxmlrpc simplepie
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-83336 using repository: https://github.com/andrewnicols/moodle.git

main (0 errors / 1 warnings) [branch: MDL-83336-main | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The MDL-83336-main branch at https://github.com/andrewnicols/moodle.git has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Mon 18 Nov 2024 04:46:20 AM UTC
Show
Code verified against automated checks with warnings. Checked MDL-83336 using repository: https://github.com/andrewnicols/moodle.git main (0 errors / 1 warnings) [branch: MDL-83336-main | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-83336 -main branch at https://github.com/andrewnicols/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Mon 18 Nov 2024 04:46:20 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch MDL-83336-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17372/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59286/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59287/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59288/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59289/ App tests (stable app version)

Built on: Mon Nov 18 04:25:16 AM UTC 2024
Show
Launching automatic jobs for branch MDL-83336 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17372/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59286/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59287/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59288/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59289/ App tests (stable app version) Built on: Mon Nov 18 04:25:16 AM UTC 2024

https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names

➜  moodle git:(php84) gg xml_set_object

backup/util/xml/parser/progressive_parser.class.php:        xml_set_object($this->xml_parser, $this);

lib/adodb/adodb-xmlschema.inc.php:                                      xml_set_object( $parser,  $index );

lib/adodb/adodb-xmlschema.inc.php:                                      xml_set_object( $parser, $data );

lib/adodb/adodb-xmlschema.inc.php:                              xml_set_object( $parser, $this->parent );

lib/adodb/adodb-xmlschema.inc.php:                              xml_set_object( $parser, $this->parent );

lib/adodb/adodb-xmlschema.inc.php:                              xml_set_object( $parser, $this->parent );

lib/adodb/adodb-xmlschema.inc.php:                              xml_set_object( $parser, $this->parent );

lib/adodb/adodb-xmlschema.inc.php:              xml_set_object( $xmlParser, $this );

lib/adodb/adodb-xmlschema.inc.php:                              xml_set_object( $parser, $this->obj );

lib/adodb/adodb-xmlschema.inc.php:                                      xml_set_object( $parser, $this->obj );

lib/adodb/adodb-xmlschema03.inc.php:                                    xml_set_object( $parser,  $index );

lib/adodb/adodb-xmlschema03.inc.php:                                    xml_set_object( $parser, $data );

lib/adodb/adodb-xmlschema03.inc.php:                            xml_set_object( $parser, $this->parent );

lib/adodb/adodb-xmlschema03.inc.php:                            xml_set_object( $parser, $this->parent );

lib/adodb/adodb-xmlschema03.inc.php:                            xml_set_object( $parser, $this->parent );

lib/adodb/adodb-xmlschema03.inc.php:                            xml_set_object( $parser, $this->parent );

lib/adodb/adodb-xmlschema03.inc.php:            xml_set_object( $xmlParser, $this );

lib/adodb/adodb-xmlschema03.inc.php:                            xml_set_object( $parser, $this->obj );

lib/adodb/adodb-xmlschema03.inc.php:                                    xml_set_object( $parser, $this->obj );

lib/dtl/xml_database_importer.php:        xml_set_object($parser, $this);

lib/phpxmlrpc/Helper/XMLParser.php:        xml_set_object($parser, $this);

lib/simplepie/src/Parser.php:            xml_set_object($xml, $this);

lib/tcpdf/tcpdf.php:            xml_set_object($parser, $this);

lib/webdavlib.php:                        xml_set_object($this->_parser, $this);

lib/webdavlib.php:                        xml_set_object($this->_parser, $this);

lib/webdavlib.php:                        xml_set_object($this->_parser, $this);

mnet/xmlrpc/xmlparser.php:        xml_set_object($this->parser, $this);

mod/scorm/datamodels/scormlib.php:        xml_set_object($this->resparser, $this);

Also many uses for xml_set_*_handler using string methods, including in:

lib/adodb/adodb-xmlschema.inc.php
lib/adodb/adodb-xmlschema03.inc.php
lib/dtl/xml_database_importer.php
lib/phpxmlrpc/Helper/XMLParser.php
lib/phpxmlrpc/Server.php
lib/simplepie/src/Parser.php
lib/tcpdf/tcpdf.php
lib/webdavlib.php
mnet/xmlrpc/xmlparser.php
mod/scorm/datamodels/scormlib.php

has been marked as being related by

MDL-83605 PR only: MDL-83336 - Deprecation of xml_set_object(), and passing string method names to xml_set_*_handler methods

Closed

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Huong Nguyen

Participants:: Andrew Lyons, CiBoT, Huong Nguyen

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 02/Oct/24 11:26 AM

Updated:: 3 days ago 12:54 AM

Estimated:

Not Specified

Remaining:

Logged:

59m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify