Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.1
Affects Version/s: 4.5 regressions, 4.5
Component/s: Course
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/marinaglancy/moodle
Pull 4.5 Branch:
~~MDL-83430~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...marinaglancy:moodle:MDL-83430-405
Pull Main Branch:
~~MDL-83430~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...marinaglancy:moodle:MDL-83430
Testing Instructions:
Hide

There is only one provider in core, it is covered with automated tests.

Manual tests:

install plugin https://github.com/ilyatregubov/moodle-tool_customprovider

As admin go to course/customfield.php

Click "Add a new custom field" and select CF type "Number"

Add your field a name and a short name (ignore other configuration, it is not relevant)

In Field type select "Custom provider" and save

Go to any course page and navigate to settings

In "Other field section" click "Update" next to you field name

Observe field is updated with image and a link (which is link to image)
Show
There is only one provider in core, it is covered with automated tests. Manual tests: install plugin https://github.com/ilyatregubov/moodle-tool_customprovider As admin go to course/customfield.php Click "Add a new custom field" and select CF type "Number" Add your field a name and a short name (ignore other configuration, it is not relevant) In Field type select "Custom provider" and save Go to any course page and navigate to settings In "Other field section" click "Update" next to you field name Observe field is updated with image and a link (which is link to image)
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83430~~-405

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57854/ Behat (NonJS - boost and classic / --tags @customfield_number)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57855/ Behat (Firefox - boost / --tags @customfield_number)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57856/ Behat (Firefox - classic / --tags @customfield_number)

Launching automatic jobs for branch ~~MDL-83430~~

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57857/ Behat (NonJS - boost and classic / --tags @customfield_number)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57858/ Behat (Firefox - boost / --tags @customfield_number)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57859/ Behat (Firefox - classic / --tags @customfield_number)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57860/ App tests (stable app version) / --tags @customfield_number)

Built on: Mon Oct 14 10:47:46 UTC 2024
Show
Launching automatic jobs for branch MDL-83430 -405 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57854/ Behat (NonJS - boost and classic / --tags @customfield_number) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57855/ Behat (Firefox - boost / --tags @customfield_number) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57856/ Behat (Firefox - classic / --tags @customfield_number) Launching automatic jobs for branch MDL-83430 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57857/ Behat (NonJS - boost and classic / --tags @customfield_number) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57858/ Behat (Firefox - boost / --tags @customfield_number) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57859/ Behat (Firefox - classic / --tags @customfield_number) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57860/ App tests (stable app version) / --tags @customfield_number) Built on: Mon Oct 14 10:47:46 UTC 2024

In ~~MDL-82715~~ we introduced providers for the customfield_number that automatically populate the field with some calculated values.

However we made a mistake in the \customfield_number\field_controller::prepare_field_for_display() and it calls the provider too late.

It assumes that every provider has 'decimalplaces' and 'displaywhenzero' properties. And also applies format_string() always, even if provider wants to return some html that should not be cleaned.

To preserve the behavior of the default method we will move format_string() call into the default implementation of the customfield_number\provider_base::prepare_export_value()

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83430.png
415 kB
23/Oct/24 5:05 PM

is a regression caused by

MDL-82715 Add option for automatically populated values for the 'number' custom field

Closed

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Ilya Tregubov

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Ilya Tregubov, Jun Pataleta, Marina Glancy, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 10/Oct/24 7:59 PM

Updated:: 25/Oct/24 10:33 AM

Resolved:: 25/Oct/24 10:33 AM

Estimated:

Remaining:

Logged:

1d 30m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify