Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.3.8, 4.4.4
Component/s: Enrolments
Labels:

Affected Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-83432~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83432-404
Pull 4.5 Branch:
~~MDL-83432~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83432-405
Pull Main Branch:
~~MDL-83432~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83432
Testing Instructions:
Hide

Log in as admin

Create a user

Create a course

Navigate to course enrolment methods

Edit the Manual enrolments method

Change custom welcome message:

Hi {$a->firstname}, you are enrolled in the course {$a->coursename} as a {$a->courserole}

Manually enrol test user as a Teacher on the course

Confirm test user received an email informing them they were enrolled as a teacher
Show
Log in as admin Create a user Create a course Navigate to course enrolment methods Edit the Manual enrolments method Change custom welcome message: Hi {$a->firstname}, you are enrolled in the course {$a->coursename} as a {$a->courserole} Manually enrol test user as a Teacher on the course Confirm test user received an email informing them they were enrolled as a teacher
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83432~~ using repository: https://github.com/paulholden/moodle/

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83432-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83432-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83432 | CI Job]

_{More information about this report}

Built on: Fri 18 Oct 2024 02:34:07 PM UTC
Show
Code verified against automated checks. Checked MDL-83432 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83432-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83432-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83432 | CI Job ] More information about this report Built on: Fri 18 Oct 2024 02:34:07 PM UTC

When setting up a Manual enrollment course welcome message, the User course role {$a->courserole} placeholder always displays "student" when it triggers. For example, if a Teacher or Manager is enrolled in a course, the message they receive in their course welcome message is that they've been enrolled as a "Student".

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

image-2024-10-11-10-28-16-598.png
67 kB
11/Oct/24 4:28 PM
image-2024-10-11-10-29-22-104.png
212 kB
11/Oct/24 4:29 PM
MDL-83432.png
97 kB
24/Oct/24 11:33 AM
Screenshot 2024-10-10 at 9.17.05 AM.png
18 kB
10/Oct/24 9:19 PM

is a regression caused by

MDL-4188 Send course welcome message for manual and self enrolments

Closed

Testing discovered

MDL-83443 Course enrolment uses non-translatable role shortname in welcome message

Closed

Assignee:: Paul Holden

Reporter:: John Provasnik

Peer reviewer:: Laurent David

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Huong Nguyen, John Provasnik, Laurent David, Luca Bösch, Marina Glancy, Mary Cooch, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 10/Oct/24 9:19 PM

Updated:: 10/Dec/24 6:07 PM

Resolved:: 25/Oct/24 10:33 AM

Estimated:

Not Specified

Remaining:

Logged:

2h 29m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify