-
Bug
-
Resolution: Fixed
-
Minor
-
4.3.9, 4.4.5, 4.5.1
-
MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
-
MOODLE_404_STABLE, MOODLE_405_STABLE
-
MDL-83463-404 -
MDL-83463-405 -
-
Code verified against automated checks. 
Checked
MDL-83463using repository: https://github.com/paulholden/moodle/
MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83463-404 | CI Job]- MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83463-405 | CI Job]
- main (0 errors / 0 warnings) [branch: MDL-83463 | CI Job]
Code verified against automated checks. Checked MDL-83463 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83463-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83463-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83463 | CI Job ] More information about this report -
The 'Include files' setting (backup_general_files) from General backup settings is meant to "Sets the default for including files in a backup", but this isn't being set as the default for backups in the UI.
It looks like apply_config_defaults() doesn't load this default at all. All other general backup settings are loaded here.
From my testing the Include files option in the backup is still working as intended, it just isn't loading the default from general backup settings.
Steps to reproduce:
- Go to Site administration > Courses > Backups > General Backup defaults. (admin/settings.php?section=backupgeneralsettings)
- Uncheck 'Include files' (backup_general_files) and save changes.
- Open a course and from course reuse load the backup page. (backup/backup.php?id=1)
- 'Include files' will still be checked
