Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.9, 4.5.5, 5.0.1
Affects Version/s: 4.5
Component/s: Administration
Labels:
- CatalystIT
- ci
- hqteam_hedgehog
- partner
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-83537~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83537-404
Pull 4.5 Branch:
~~MDL-83537~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83537-405
Pull Main Branch:
~~MDL-83537~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83537

Testing Instructions:

Hide

Log in as admin
Navigate to site administration
Search for "checkantivirus"
Confirm presence of Manage antivirus plugins link

Make the following change (remove the action link from the antivirus check):

$ git diff lib/classes/check/environment/antivirus.php

diff --git a/lib/classes/check/environment/antivirus.php b/lib/classes/check/environment/antivirus.php

index ce3dd23fb86..dec13881849 100644

--- a/lib/classes/check/environment/antivirus.php

+++ b/lib/classes/check/environment/antivirus.php

@@ -41,17 +41,6 @@ class antivirus extends check {

         return get_string('check_antivirus_name', 'report_security');

-    /**

-     * A link to a place to action this

-     *

-     * @return \action_link|null

-     */

-    public function get_action_link(): ?\action_link {

-        return new \action_link(

-            new \moodle_url('/admin/settings.php', ['section' => 'manageantiviruses']),

-            get_string('antivirussettings', 'antivirus'));

-    }

/**

      * Return result

      * @return result

Search again for "checkantivirus"
Confirm link is no longer present and there are no errors/exceptions

Show

Log in as admin Navigate to site administration Search for "checkantivirus" Confirm presence of Manage antivirus plugins link Make the following change (remove the action link from the antivirus check): $ git diff lib/classes/check/environment/antivirus.php diff --git a/lib/classes/check/environment/antivirus.php b/lib/classes/check/environment/antivirus.php index ce3dd23fb86..dec13881849 100644 --- a/lib/classes/check/environment/antivirus.php +++ b/lib/classes/check/environment/antivirus.php @@ -41,17 +41,6 @@ class antivirus extends check { return get_string('check_antivirus_name', 'report_security'); } - /** - * A link to a place to action this - * - * @return \action_link|null - */ - public function get_action_link(): ?\action_link { - return new \action_link( - new \moodle_url('/admin/settings.php', ['section' => 'manageantiviruses']), - get_string('antivirussettings', 'antivirus')); - } - /** * Return result * @return result Search again for "checkantivirus" Confirm link is no longer present and there are no errors/exceptions

Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83537~~ using repository: https://github.com/paulholden/moodle/

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83537-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83537-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83537 | CI Job]

_{More information about this report}

Built on: Tue Mar 18 20:18:23 UTC 2025
Show
Code verified against automated checks. Checked MDL-83537 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83537-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83537-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83537 | CI Job ] More information about this report Built on: Tue Mar 18 20:18:23 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83537~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18654/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63901/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63902/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83537~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18655/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63903/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63904/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83537~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18656/ PHPUnit (sqlsrv) --> known random, please ignore.

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63905/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63906/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63907/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63908/ App tests (stable app version)

Built on: Tue Mar 18 20:25:22 UTC 2025
Show
Launching automatic jobs for branch MDL-83537 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18654/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63901/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63902/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83537 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18655/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63903/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63904/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83537 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18656/ PHPUnit (sqlsrv) --> known random, please ignore. https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63905/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63906/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63907/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63908/ App tests (stable app version) Built on: Tue Mar 18 20:25:22 UTC 2025

check classes may not have action links, they are allowed to return null.

However here the code assumes it always has an action link:

https://github.com/moodle/moodle/blob/ecfcf00d92df2e874da9d8cb31750403ada7789a/lib/adminlib.php#L11813

But if a check doesn't, it throws an exception:

Exception - renderer_base::render(): Argument #1 ($widget) must be of type renderable, null given, called in [dirroot]/lib/adminlib.php on line 11813

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 4 Passed -- (Main)MDL-83537.png
134 kB
16/Apr/25 4:51 PM
(1) 7 Passed -- (Main)MDL-83537.png
188 kB
16/Apr/25 4:51 PM

is a regression caused by

MDL-67898 Have an admin_setting which exposes a check

Closed

Assignee:: Paul Holden

Reporter:: Matthew Hilton

Peer reviewer:: Daniel Ziegenberg

Integrator:: Sara Arjona (@sarjona)

Tester:: Kim Jared Lucas

Participants:: CiBoT, Daniel Ziegenberg, Jun Pataleta, Kim Jared Lucas, Matthew Hilton, Paul Holden, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 24/Oct/24 8:15 AM

Updated:: Yesterday 8:57 PM

Resolved:: Yesterday 8:57 PM

Estimated:

Not Specified

Remaining:

Logged:

22m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify