Summary

If the rubric option 'Allow grader to add text remarks for each criterion' is disabled, when deselecting an already selected rubric criterion grade in the assignment grader screen (changing a user's grade for a criterion to 'no grade'), their grade in the gradebook is updated to reflect the change i.e. 'no grade'. However, the previously selected criterion grade is still toggled as "selected" visually. Upon re-saving and not making any changes, the highlighted/toggled criterion grade is saved, causing the grade to unexpectedly change to reflect what was previously selected, rather than hold the deselection (no grade) the user had selected.

Steps to replicate:

1. Create a new Assignment activity and give it a name
2. Scroll down to 'Grade' and for Grading method select 'Rubric'
3. Click Save and display (you will redirect to the Rubric screen)
4. Click 'Define new grading form from scratch'
5. Enter a name for the rubric
6. Click 'Click to edit criterion' and enter some text.
7. Click 'Click to edit level' for each grade value and add some text
8. Under 'Rubric options' uncheck the option 'Allow grader to add text remarks for each criterion' this step is important - cannot be replicated without!
9. Click Save rubric and make it ready
10. Click 'Grade' to go to the assignment grader screen
11. Select the any of the grade options e.g. 0 points
12. Click 'Save changes' at the bottom - Observe 'current grade in gradebook'
13. Click the same grade option again e.g. 0 points to deselect it - Observe criterion green highlight
14. Save changes again without changing anything - Observe 'current grade in gradebook'

Observed behaviour (screen recording attached):

When first selecting a grade for the criterion and saving, it is correctly saved in the gradebook

When deselecting the grade and saving again, the grade is correctly saved in the gradebook, but the previously selected grade value in the rubric is highlighted green as if it had been selected

When saving again without making any further changes, the grade saved in gradebook is set to the grade value that was still highlighted in green, even though the user did not select this themselves

Expected behaviour:

When first selecting a grade for the criterion and saving, it is correctly saved in the gradebook

When deselecting the grade and saving again, the 'no grade' value is correctly saved in the gradebook. The grade will be completely deselected and not highlighted in green

When saving again without making any further changes, the grade saved in gradebook will remain as 'no grade' as no changes have been made by the user