Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.0 regressions, 4.4.5, 4.5
Component/s: JavaScript
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.4 Branch:
MDL-83580-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83580-404
Pull 4.5 Branch:
MDL-83580-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83580-405
Pull Main Branch:
MDL-83580
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83580
Testing Instructions:
Hide

Perform tests in both Chrome & Firefox

Test fix

Open browser developer console

Log in as admin

Press on the question mark in the page footer to open the footer popup

Move focus out of the browser window (click on your desktop)

Now move focus back into your browser window (click somewhere on the page)

Confirm there is no error in the browser console

Confirm the footer popup is closed

Regression test

Repeat all steps from ~~MDL-73609~~
Show
Perform tests in both Chrome & Firefox Test fix Open browser developer console Log in as admin Press on the question mark in the page footer to open the footer popup Move focus out of the browser window (click on your desktop) Now move focus back into your browser window (click somewhere on the page) Confirm there is no error in the browser console Confirm the footer popup is closed Regression test Repeat all steps from MDL-73609
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-83580 using repository: https://github.com/paulholden/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83580-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83580-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83580 | CI Job]

_{More information about this report}

Built on: Mon 04 Nov 2024 10:49:20 PM UTC
Show
Code verified against automated checks. Checked MDL-83580 using repository: https://github.com/paulholden/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83580-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83580-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83580 | CI Job ] More information about this report Built on: Mon 04 Nov 2024 10:49:20 PM UTC

STEPS TO REPLICATE

Use Firefox browser
Open a new tab and access Moodle
Open the web developer console. Focus on the console tab.
Click the question mark icon at the bottom right. Keep it open.
Open the new browser tab
Back to the first browser tab where the Moodle exist.

EXPECTED

There is no error in the console.

ACTUAL

There is an error in the console.

Uncaught TypeError: e.target.closest is not a function

NOTE

It did not happen on Chrome and Opera.

is a regression caused by

MDL-73609 New 4.0 footer: minor usability/accessibility issues

Closed

Assignee:: Paul Holden

Reporter:: Meirza

Participants:: Andrew Lyons, Meirza, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 29/Oct/24 12:03 AM

Updated:: 04/Mar/25 7:30 PM

Details

Test fix

Regression test

Description

Attachments

Issue Links

Activity

People

Dates

Clockify