Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.4.4, 4.5
Component/s: Gradebook
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/DSI-Universite-Rennes2/moodle
Pull 4.4 Branch:
83617-fix-grader-report-url-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...DSI-Universite-Rennes2:moodle:83617-fix-grader-report-url-404
Pull 4.5 Branch:
83617-fix-grader-report-url-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...DSI-Universite-Rennes2:moodle:83617-fix-grader-report-url-405
Pull Main Branch:
83617-fix-grader-report-url-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...DSI-Universite-Rennes2:moodle:83617-fix-grader-report-url-main
Testing Instructions:
Hide

Covered by automated tests (Behat)

For manual test:

Setup:

Create an empty course

Test:

Go to grades tab

In the dropdown menu show at the bottom left of the page, change the value (20, 100 or all)

Check in the address bar of your browser that the new url does not contains the following string "&amp"
Show
Covered by automated tests (Behat) For manual test: Setup: Create an empty course Test: Go to grades tab In the dropdown menu show at the bottom left of the page, change the value (20, 100 or all) Check in the address bar of your browser that the new url does not contains the following string "&amp"
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83617~~ using repository: https://github.com/DSI-Universite-Rennes2/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: 83617-fix-grader-report-url-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: 83617-fix-grader-report-url-405 | CI Job]

main (0 errors / 0 warnings) [branch: 83617-fix-grader-report-url-main | CI Job]

_{More information about this report}

Built on: Wed 20 Nov 2024 03:18:33 AM UTC
Show
Code verified against automated checks. Checked MDL-83617 using repository: https://github.com/DSI-Universite-Rennes2/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: 83617-fix-grader-report-url-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: 83617-fix-grader-report-url-405 | CI Job ] main (0 errors / 0 warnings) [branch: 83617-fix-grader-report-url-main | CI Job ] More information about this report Built on: Wed 20 Nov 2024 03:18:33 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch 83617-fix-grader-report-url-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17419/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59417/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59418/ Behat (Firefox - boost)

Launching automatic jobs for branch 83617-fix-grader-report-url-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17420/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59419/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59420/ Behat (Firefox - boost)

Launching automatic jobs for branch 83617-fix-grader-report-url-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17421/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59421/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59422/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59423/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59424/ App tests (stable app version)

Built on: Wed Nov 20 04:25:21 AM UTC 2024
Show
Launching automatic jobs for branch 83617-fix-grader-report-url-404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17419/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59417/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59418/ Behat (Firefox - boost) Launching automatic jobs for branch 83617-fix-grader-report-url-405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17420/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59419/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59420/ Behat (Firefox - boost) Launching automatic jobs for branch 83617-fix-grader-report-url-main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17421/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59421/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59422/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59423/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59424/ App tests (stable app version) Built on: Wed Nov 20 04:25:21 AM UTC 2024

In grader report, when you change the number of grades per page, you are redirected to a page with invalid url.

The new url is encoded twice. The url contains & string instead of & character.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

83617 peer review behat test.png
43 kB
19/Nov/24 3:26 PM
83617 peer review test.png
42 kB
14/Nov/24 5:08 PM
image-2024-11-19-10-05-50-286.png
33 kB
19/Nov/24 5:05 PM

Assignee:: Julien Boulen

Reporter:: Julien Boulen

Peer reviewer:: Andrew Gosali

Integrator:: Glyn (Mathew) May

Tester:: CiBoT

Participants:: Andrew Gosali, CiBoT, Glyn (Mathew) May, Julien Boulen, Mihail Geshoski, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 02/Nov/24 1:23 AM

Updated:: 07/Feb/25 1:02 PM

Resolved:: 31/Jan/25 10:48 AM

Estimated:

Remaining:

Logged:

6h 2m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify