Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.7, 4.5.3
Affects Version/s: 4.2 regressions, 4.3.9, 4.4.5
Component/s: Gradebook
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.4 Branch:
~~MDL-83645~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83645-404
Pull 4.5 Branch:
~~MDL-83645~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83645-405
Pull Main Branch:
~~MDL-83645~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83645
Testing Instructions:
1. Covered by automated tests (PHPUnit)
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-83645~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83645-404 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-83645~~-404 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83645-405 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-83645~~-405 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

main (0 errors / 1 warnings) [branch: MDL-83645 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-83645~~ branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Mon Feb 10 11:29:30 AM UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-83645 using repository: https://github.com/paulholden/moodle.git MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83645-404 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-83645 -404 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83645-405 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-83645 -405 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). main (0 errors / 1 warnings) [branch: MDL-83645 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-83645 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Mon Feb 10 11:29:30 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83645~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18219/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62232/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62233/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83645~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18220/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62234/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62235/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83645~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18221/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62236/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62237/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62238/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62239/ App tests (stable app version) --> unrelated failure, needs rebase.

Built on: Mon Feb 10 10:30:57 AM UTC 2025
Show
Launching automatic jobs for branch MDL-83645 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18219/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62232/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62233/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83645 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18220/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62234/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62235/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83645 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18221/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62236/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62237/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62238/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62239/ App tests (stable app version) --> unrelated failure, needs rebase. Built on: Mon Feb 10 10:30:57 AM UTC 2025

See the following PHP warnings when calling the core_grading_get_gradingform_instances external service:

[Wed Nov 06 08:03:22.897667 2024] [php:warn] [pid 32:tid 32] [client 172.18.0.1:43878] PHP Warning:  Attempt to read property "id" on int in /var/www/html/lib/external/classes/util.php on line 555

172.18.0.1 - - [06/Nov/2024:08:03:22 +0000] "POST /webservice/rest/server.php?moodlewsrestformat=json HTTP/1.1" 200 608 "-" "curl/7.68.0"

It's because the text formatting inside that method is passing $context->id instead of expected $context instance

is a regression caused by

MDL-76583 Move lib/externallib.php to namespaced classes and fix coding style, etc.

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Daniel Ziegenberg

Integrator:: Huong Nguyen

Tester:: CiBoT

Participants:: CiBoT, Daniel Ziegenberg, Huong Nguyen, Jun Pataleta, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 06/Nov/24 4:24 PM

Updated:: 14/Feb/25 11:11 AM

Resolved:: 14/Feb/25 11:11 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify