Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.2.11, 4.3.9, 4.4.5, 4.5.1
Component/s: General
Labels:

Affected Branches:
MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/Cl3mensM/moodle.git
Pull 4.4 Branch:
~~MDL-83650~~-404_fix_ods_cell
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...Cl3mensM:moodle:MDL-83650-404_fix_ods_cell
Pull 4.5 Branch:
~~MDL-83650~~-405_fix_ods_cell
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...Cl3mensM:moodle:MDL-83650-405_fix_ods_cell
Pull Main Branch:
~~MDL-83650~~-main_fix_ods_cell
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...Cl3mensM:moodle:MDL-83650-main_fix_ods_cell
Testing Instructions:
Hide

Testing instructions copied from MDL-81664.

Prerequisites

To test this, you need a Moodle environment with at least PHP 8.2.

Testing scenario: The error is gone with the patch

Login as admin

Go to http://yourmoodleurl/lib/tests/other/spreadsheettestpage.php and generate the ODS sample file by clicking "Test ODS format".

Open the ODS sample file.

Verify that the content is displayed as expected (Font colours, headings, etc.). You can compare the file to an earlier export or the moodletest.ods attached to this tracker issue. The ODS file should be able to open without any issues.

Verify that there is no error in apache error log in /var/log/apache2/error.log
Show
Testing instructions copied from MDL-81664 . Prerequisites To test this, you need a Moodle environment with at least PHP 8.2. Testing scenario: The error is gone with the patch Login as admin Go to http://yourmoodleurl/lib/tests/other/spreadsheettestpage.php and generate the ODS sample file by clicking "Test ODS format". Open the ODS sample file. Verify that the content is displayed as expected (Font colours, headings, etc.). You can compare the file to an earlier export or the moodletest.ods attached to this tracker issue. The ODS file should be able to open without any issues. Verify that there is no error in apache error log in /var/log/apache2/error.log
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83650~~ using repository: https://github.com/Cl3mensM/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83650-404_fix_ods_cell | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83650-405_fix_ods_cell | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83650-main_fix_ods_cell | CI Job]

_{More information about this report}

Built on: Thu Jan 30 12:58:16 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-83650 using repository: https://github.com/Cl3mensM/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83650-404_fix_ods_cell | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83650-405_fix_ods_cell | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83650-main_fix_ods_cell | CI Job ] More information about this report Built on: Thu Jan 30 12:58:16 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83650~~-404_fix_ods_cell

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18118/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61910/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61911/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83650~~-405_fix_ods_cell

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18119/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61912/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61913/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83650~~-main_fix_ods_cell

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18120/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61914/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61915/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61916/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61917/ App tests (stable app version)

Built on: Thu Jan 30 02:30:23 PM UTC 2025
Show
Launching automatic jobs for branch MDL-83650 -404_fix_ods_cell https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18118/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61910/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61911/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83650 -405_fix_ods_cell https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18119/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61912/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61913/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83650 -main_fix_ods_cell https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18120/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61914/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61915/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61916/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61917/ App tests (stable app version) Built on: Thu Jan 30 02:30:23 PM UTC 2025

In the odslib.class.php the MoodleODSCell class uses a dynamic property, which results in a deprecation error when using PHP version 8.2/8.3.

The dynamic property is $merge.

https://github.com/moodle/moodle/blob/d015c4c21331831c73e7ca102eb9334bf20f25c4/lib/odslib.class.php#L410

Dynamic properties' deprecation info from php watch:

https://php.watch/versions/8.2/dynamic-properties-deprecated

I also created the change for MOODLE_402_STABLE:

Pull 4.2 Branch: ~~MDL-83650~~-402_fix_ods_cell

Pull 4.2 Diff URL: https://github.com/moodle/moodle/compare/MOODLE_402_STABLE...Cl3mensM:moodle:MDL-83650-402_fix_ods_cell

Workflow passing: https://github.com/Cl3mensM/moodle/actions/runs/11710604791

So, basically changed it for all versions that support PHP 8.2/8.3

Steps to reproduce

Login as admin
Turn on full debug logging
Go to http://yourmoodleurl/lib/tests/other/spreadsheettestpage.php and generate the ODS sample file by clicking "Test ODS format".
Verify you see the deprecation error Creation of dynamic property MoodleODSCell::$merge is deprecated in the error log. In ubuntu this should live in /var/log/apache/error.log

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83650.png
254 kB
05/Feb/25 3:59 PM
moodletest.ods
6 kB
30/Jan/25 9:19 PM

blocks

MDL-80117 Prepare Moodle for PHP 8.4

Open

Assignee:: Cl3mensM

Reporter:: Cl3mensM

Peer reviewer:: Daniel Ziegenberg

Integrator:: Safat Shahin

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Cl3mensM, Daniel Ziegenberg, Huong Nguyen, Jun Pataleta, Ron Carl Alfon Yu, Safat Shahin

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 06/Nov/24 10:28 PM

Updated:: 28/Feb/25 9:16 AM

Resolved:: 07/Feb/25 12:20 AM

Estimated:

Not Specified

Remaining:

Logged:

59m

Details

Prerequisites

Testing scenario: The error is gone with the patch

Description

Steps to reproduce

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify