Prerequisites

• Create a course with a page activity
• Have the TinyMCE as the prefered editor.

Test instructions

First part

• Edit the page activity, change to the source view in the Tiny and add the following text:

• Hit the Save button to switch back to WYSIWYG mode.
• Go back to the source code button.

Expected outcome: the onclick attribute vanished.

Second part

• Change the settings, go to the Site administration -> Plugins -> Text editors -> TinyMCE editor -> General settings.
• Change the value of editor_tiny | extended_valid_elements to script[*],p[*],i[*],button[onclick] and click save.
• Go to the page activity, repeat the steps from above.

Expected outcome: This time after switching back from the WYSIWYG mode again into the source code mode, the onclick attribute should be still inside the button element.

Code verified against automated checks.

Checked MDL-83668 using repository: https://github.com/srobotta/moodle

• MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83668-404 | CI Job]
• MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83668-405 | CI Job]

_{More information about this report}

Built on: Thu 21 Nov 2024 04:31:48 AM UTC

Launching automatic jobs for branch MDL-83668-404

• https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17296/ PHPUnit (sqlsrv)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58939/ Behat (NonJS - boost and classic)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58940/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-83668-405

• https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17297/ PHPUnit (sqlsrv)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58941/ Behat (NonJS - boost and classic)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58942/ Behat (Firefox - boost)

Built on: Fri Nov 8 04:25:16 PM UTC 2024