Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 4.5.2
Affects Version/s: 4.5
Component/s: Administration, Messages
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/meirzamoodle/moodle.git
Pull 4.5 Branch:
~~MDL-83691~~-405
Pull 4.5 Diff URL:
https://github.com/meirzamoodle/moodle/compare/4bd3217ce8...MDL-83691-405
Pull Main Branch:
~~MDL-83691~~-main
Pull Main Diff URL:
https://github.com/meirzamoodle/moodle/compare/0888a6d324...MDL-83691-main
Testing Instructions:
Hide

Do not apply the patch yet.

Logging in as Admin

Navigate to Site Admin > Plugins > Admin Tools > Manage Multi-Factor Authentication.

In the Manage Multi-Factor Authentication table, click on the link for the SMS mobile phone factor settings.

Click the "Set Up an SMS Gateway" link.

Enter "Test Gateway" as the Gateway name.

Click the Save Changes button.

VERIFY that you are redirected to the SMS mobile phone settings page.

View data of `sms_gateways` database table.

VERIFY the config column for the "Test Gateway" contains `saveandreturn` and `returnurl` keys.

Apply the patch and upgrade the Moodle.

VERIFY the upgrade process is successful.

View data of `sms_gateways` database table.

VERIFY the config column for the "Test Gateway" doesn't contain `saveandreturn` and `returnurl` keys anymore.

Navigate to Site Admin > Plugins > SMS > Manage SMS Gateways.

Edit the "Test Gateway."

Click the Cancel button.

VERIFY that you have been redirected to the Manage SMS Gateways page.
Show
Do not apply the patch yet. Logging in as Admin Navigate to Site Admin > Plugins > Admin Tools > Manage Multi-Factor Authentication . In the Manage Multi-Factor Authentication table, click on the link for the SMS mobile phone factor settings. Click the "Set Up an SMS Gateway" link. Enter "Test Gateway" as the Gateway name. Click the Save Changes button. VERIFY that you are redirected to the SMS mobile phone settings page. View data of `sms_gateways` database table. VERIFY the config column for the "Test Gateway" contains `saveandreturn` and `returnurl` keys. Apply the patch and upgrade the Moodle. VERIFY the upgrade process is successful. View data of `sms_gateways` database table. VERIFY the config column for the "Test Gateway" doesn't contain `saveandreturn` and `returnurl` keys anymore. Navigate to Site Admin > Plugins > SMS > Manage SMS Gateways . Edit the "Test Gateway." Click the Cancel button. VERIFY that you have been redirected to the Manage SMS Gateways page.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83691~~ using repository: https://github.com/meirzamoodle/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83691-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83691-main | CI Job]

_{More information about this report}

Built on: Wed 11 Dec 2024 02:57:37 AM UTC
Show
Code verified against automated checks. Checked MDL-83691 using repository: https://github.com/meirzamoodle/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83691-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83691-main | CI Job ] More information about this report Built on: Wed 11 Dec 2024 02:57:37 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83691~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17588/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59896/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59897/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83691~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17589/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59898/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59899/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59900/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59901/ App tests (stable app version)

Built on: Fri Nov 29 12:25:21 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83691 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17588/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59896/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59897/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83691 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17589/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59898/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59899/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59900/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59901/ App tests (stable app version) Built on: Fri Nov 29 12:25:21 PM UTC 2024

Story Points:
2
Sprint:
Team Hedgehog 2024 Sprint 4.2, Team Hedgehog 2024 Sprint 4.3

After setting up the MFA sms factor, the cancel and save changes form submission in the SMS gateway management form always takes back to the MFA settings page.

Steps to reproduce:

Enable MFA plugin
Enable SMS factor
Go to SMS factor settings
Click the link to create a gateway
Save changes and it will take you back to MFA settings page
Now go to SMS gateway manage page (Site administration > SMS > Manage sms gateway)
Edit a gateway
Click cancel
Expected: back to the sms gateway management page
Actual: goes back to mfa settings page
Same situation for save changes button

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83691.png
727 kB
18/Dec/24 2:38 PM

Assignee:: Meirza

Reporter:: Safat Shahin

Peer reviewer:: Raquel Ortega

Integrator:: Safat Shahin

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Jun Pataleta, Meirza, Raquel Ortega, Ron Carl Alfon Yu, Safat Shahin

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 12/Nov/24 7:48 AM

Updated:: 04/Feb/25 1:56 PM

Resolved:: 19/Dec/24 8:27 PM

Estimated:

Remaining:

Logged:

1d 6h

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify