Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.5
Component/s: Navigation
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/srobotta/moodle
Pull 4.3 Branch:
~~MDL-83746~~-403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...srobotta:moodle:MDL-83746-403
Pull 4.4 Branch:
~~MDL-83746~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...srobotta:moodle:MDL-83746-404
Pull 4.5 Branch:
~~MDL-83746~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...srobotta:moodle:MDL-83746-405
Pull Main Branch:
~~MDL-83746~~-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...srobotta:moodle:MDL-83746-main
Testing Instructions:
Hide

Login as admin

Set the custommenuitems setting to:

Moodle|https://moodle.org

Go to the site homepage

Check that, in the main navigation, a "Moodle" node is added as the last item.

Check the "Home" node is highlighted as active.

Check the "Moodle" node at the right is not highlighted e.g. being inactive.
Show
Login as admin Set the custommenuitems setting to: Moodle|https://moodle.org Go to the site homepage Check that, in the main navigation, a "Moodle" node is added as the last item. Check the "Home" node is highlighted as active. Check the "Moodle" node at the right is not highlighted e.g. being inactive.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83746~~ using repository: https://github.com/srobotta/moodle

MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-83746-403 | CI Job]

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83746-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83746-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83746-main | CI Job]

_{More information about this report}

Built on: Tue 19 Nov 2024 08:39:40 AM UTC
Show
Code verified against automated checks. Checked MDL-83746 using repository: https://github.com/srobotta/moodle MOODLE_403_STABLE (0 errors / 0 warnings) [branch: MDL-83746-403 | CI Job ] MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83746-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83746-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83746-main | CI Job ] More information about this report Built on: Tue 19 Nov 2024 08:39:40 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83746~~-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17453/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59520/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59521/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59522/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83746~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17454/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59523/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59524/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59525/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83746~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17455/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59526/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59527/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59528/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-83746~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17456/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59529/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59530/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59531/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59532/ App tests (stable app version) / complete)

Built on: Wed Nov 20 11:30:29 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83746 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17453/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59520/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59521/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59522/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83746 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17454/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59523/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59524/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59525/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83746 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17455/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59526/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59527/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59528/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-83746 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17456/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59529/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59530/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59531/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59532/ App tests (stable app version) / complete) Built on: Wed Nov 20 11:30:29 PM UTC 2024

Steps to reproduce:

Login as admin
Set the custommenuitems setting to:
Moodle|https://moodle.org
Go to the site homepage

Expected result:

You are on the site homepage
In the main navigation, a "Moodle" node is added as the last item
The "Home" node is highlighted as active

Actual result:

You are on the site homepage
In the main navigation, a "Moodle" node is added as the last item
The "Moodle" node is highlighted as active

Note:
This might be a regression of ~~MDL-77732~~ , but even if it's not a regression then it is at least related.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 6 Passed -- (Main)MDL-83746.png
53 kB
08/Jan/25 10:56 AM
screenshot-1.png
102 kB
18/Nov/24 6:08 PM

has a non-specific relationship to

MDL-77732 Links added in the navbar do not receive focus/active behaviour (custommenuitems) on the Boost theme - Take 2

Closed

Assignee:: Stephan Robotta

Reporter:: Alexander Bias

Peer reviewer:: Alexander Bias

Integrator:: Sara Arjona (@sarjona)

Tester:: Kim Jared Lucas

Participants:: Alexander Bias, CiBoT, Kim Jared Lucas, Sara Arjona (@sarjona), Simey Lameze, Stephan Robotta

Votes:: 3 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 18/Nov/24 6:08 PM

Updated:: 4 days ago 10:38 PM

Resolved:: 4 days ago 10:38 PM

Estimated:

Remaining:

Logged:

19m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify