Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.1
Affects Version/s: 4.5, 5.0
Component/s: Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 4.5 Branch:
~~MDL-83811~~-405
Pull 4.5 Diff URL:
https://github.com/junpataleta/moodle/compare/485130d7c5...MDL-83811-405
Pull Main Branch:
~~MDL-83811~~-main
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/505a85eb9a...MDL-83811-main
Testing Instructions:
Hide

PGSQL

Inspect the PHPUnit runs for the following builds:

main

405

Confirm that the following errors/failures/debugging are no longer present in the build.

(405 and main) Failed to connect exception/debugging related to Redis.

(main only) core\component_test::test_composer_files failures.

(main only) core\dml_pgsql_read_replica_test::test_real_readreplica_connect_fail failure

The only errors you should see on the build are the isolation test errors like below, which will be fixed in MDL-79943 instead.

core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: When including this file for a unit test, the test must be run in an isolated process. See the PHPUnit @runInSeparateProcess and @runTestsInSeparateProcesses annotations.

read_replica tests on MySQL (main only)

Confirm that this build that runs only the read_replica-related tests is passing on MySQL.
Show
PGSQL Inspect the PHPUnit runs for the following builds: main 405 Confirm that the following errors/failures/debugging are no longer present in the build. (405 and main) Failed to connect exception/debugging related to Redis. (main only) core\component_test::test_composer_files failures. (main only) core\dml_pgsql_read_replica_test::test_real_readreplica_connect_fail failure The only errors you should see on the build are the isolation test errors like below, which will be fixed in MDL-79943 instead. core\exception\coding_exception: Coding error detected, it must be fixed by a programmer: When including this file for a unit test, the test must be run in an isolated process. See the PHPUnit @runInSeparateProcess and @runTestsInSeparateProcesses annotations. read_replica tests on MySQL (main only) Confirm that this build that runs only the read_replica-related tests is passing on MySQL.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83811~~ using repository: https://github.com/junpataleta/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83811-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83811-main | CI Job]

_{More information about this report}

Built on: Wed 27 Nov 2024 08:17:23 AM UTC
Show
Code verified against automated checks. Checked MDL-83811 using repository: https://github.com/junpataleta/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83811-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83811-main | CI Job ] More information about this report Built on: Wed 27 Nov 2024 08:17:23 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83811~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17552/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59759/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59760/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83811~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17553/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59761/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59762/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59763/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59764/ App tests (stable app version)

Built on: Wed Nov 27 08:28:02 UTC 2024
Show
Launching automatic jobs for branch MDL-83811 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17552/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59759/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59760/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83811 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17553/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59761/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59762/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59763/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59764/ App tests (stable app version) Built on: Wed Nov 27 08:28:02 UTC 2024

Windows PHPUnit runs on GitHub Actions seem to have been failing since 4.5.

There are four main issues:

Redis 3.0 is being used when the minimum Redis version has been bumped to 5.0 in 4.5.
- Can be fixed by using redis with version 5.0 instead of redis-64
Coding exceptions related to tests that need to be run in isolation
- This is already reported in MDL-79943.
core\dml_pgsql_read_replica_test::test_real_readreplica_connect_fail() failure
- Affects the main branch only. Introduced by ~~MDL-72077~~.
core\component_test::test_composer_files() failures
- Affects main only. Due to the leading backslash in the relative path not being trimmed for Windows.

Here's an example run.

Discovered while testing

MDL-83470 Decide Moodle 5.0 requirements and push them to environment.xml (due date: 15 Nov 2024)

Closed

is a regression caused by

MDL-66151 Performance: Allow session stores to fully manage the session

Closed

MDL-72077 moodle_read_slave_trait: additional debug logging

Closed

MDL-82824 Add unit test to check Moodle autoloader from Composer

Closed

will be (partly) resolved by

MDL-79943 Windows PHPUnit failures (isolation tests)

Open

Assignee:: Jun Pataleta

Reporter:: Jun Pataleta

Peer reviewer:: Angelia Dela Cruz

Integrator:: Simey Lameze

Tester:: Huong Nguyen

Participants:: Angelia Dela Cruz, CiBoT, Huong Nguyen, Jun Pataleta, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 25/Nov/24 10:12 PM

Updated:: 29/Nov/24 8:27 PM

Resolved:: 29/Nov/24 8:27 PM

Estimated:

Not Specified

Remaining:

Logged:

2d 1h 41m

Details

PGSQL

read_replica tests on MySQL (main only)

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify