Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.4.4, 4.5, 5.0
Component/s: Questions
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Quiz and Question bank in Moodle 5.0
Pull from Repository:
https://github.com/NashTechOpenUniversity/moodle.git
Pull 4.4 Branch:
~~MDL-83831~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...NashTechOpenUniversity:moodle:MDL-83831-404
Pull 4.5 Branch:
~~MDL-83831~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...NashTechOpenUniversity:moodle:MDL-83831-405
Pull Main Branch:
~~MDL-83831~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...NashTechOpenUniversity:moodle:MDL-83831-master
Testing Instructions:

Hide

Test Scenario: This is also covered by Behat tests in question/bank/history/tests/behat/question_history_action.feature.

1. Log in as an admin.
2. Create a course.
3. Create two questions (Question A and Question B) under the course category.
4. Go to the course question bank.
5. Verify that both Question A and Question B are displayed.
6. View the history of Question A.
7. Verify that only Question A is shown.
8. Try removing any columns in the question table (e.g., "Version").
9. Verify that the removed columns are no longer visible in the table.
10. Click the "Reset Columns" button.
11. Verify that the removed columns are now visible again.
12. Verify that the question table displays all versions of Question A.
13. Verify that the "Create New Question" button is not visible.

Show
Test Scenario: This is also covered by Behat tests in question/bank/history/tests/behat/question_history_action.feature. 1. Log in as an admin. 2. Create a course. 3. Create two questions (Question A and Question B) under the course category. 4. Go to the course question bank. 5. Verify that both Question A and Question B are displayed. 6. View the history of Question A. 7. Verify that only Question A is shown. 8. Try removing any columns in the question table (e.g., "Version"). 9. Verify that the removed columns are no longer visible in the table. 10. Click the "Reset Columns" button. 11. Verify that the removed columns are now visible again. 12. Verify that the question table displays all versions of Question A. 13. Verify that the "Create New Question" button is not visible.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83831~~ using repository: https://github.com/NashTechOpenUniversity/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83831-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83831-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83831-master | CI Job]

_{More information about this report}

Built on: Wed Jan 8 06:48:25 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-83831 using repository: https://github.com/NashTechOpenUniversity/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83831-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83831-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83831-master | CI Job ] More information about this report Built on: Wed Jan 8 06:48:25 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83831~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17829/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60751/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60752/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83831~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17830/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60753/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60754/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83831~~-master

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17831/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60755/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60756/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60757/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60758/ App tests (stable app version)

Built on: Wed Jan 8 10:31:10 UTC 2025
Show
Launching automatic jobs for branch MDL-83831 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17829/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60751/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60752/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83831 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17830/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60753/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60754/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83831 -master https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17831/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60755/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60756/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60757/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60758/ App tests (stable app version) Built on: Wed Jan 8 10:31:10 UTC 2025

Steps to reproduce:

Go to the question history page for any questoin in the question bank (E.g. https://qa.moodledemo.net/question/bank/history/history.php?entryid=167&returnurl=%2Fquestion%2Fedit.php%3Fcmid%3D1227%26cat%3D2%252C20278%26deleteall%3D1&cmid=1227 logged in as teacher.)
Click 'Reset columns'

Expected result: Not much happens unless you have previously customised the columns, and if you have, the layout is reset.

Actual result:

The contents of the table is replaces by the contents of the table on https://qa.moodledemo.net/question/edit.php?cmid=1227&cat=2%2C20278.
An unexpected 'Create new question' button appears.
But the URL is still question/bank/history/history.php, so this has not just redirected to the other page, so this is very confusing.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83831.png
199 kB
15/Jan/25 10:36 AM

is a regression caused by

MDL-74054 Give teachers more flexibility to customise their own view of the question bank

Closed

Assignee:: Khoa Nguyen Dang

Reporter:: Tim Hunt

Peer reviewer:: Mark Johnson

Integrator:: Tim Hunt

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Huong Nguyen, Khoa Nguyen Dang, Mark Johnson, Ron Carl Alfon Yu, Tim Hunt

Votes:: 1 Vote for this issue

Watchers:: 10 Start watching this issue

Created:: 28/Nov/24 3:12 AM

Updated:: 5 days ago 1:10 AM

Resolved:: 5 days ago 1:10 AM

Estimated:

Not Specified

Remaining:

Logged:

54m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify