Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.4.5, 4.5 regressions, 4.5.1
Component/s: Comments
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-83940~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-83940-404
Pull 4.5 Branch:
~~MDL-83940~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83940-405
Pull Main Branch:
~~MDL-83940~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83940
Testing Instructions:
Hide

Log in as admin

Create a course

Add a Database activity to course

Entries > Allow comments on entries: Yes

From activity page, press Use a preset

Select Journal, press Use this preset

Add an entry to the activity

View the entry

Expand the Comments section

Confirm the expand/collapse icon updates correctly

Confirm the loading icon is appropriately sized

Add a comment

Confirm the loading icon is shown again

Collapse the Comments section

Confirm the expand/collapse icon updates correctly
Show
Log in as admin Create a course Add a Database activity to course Entries > Allow comments on entries: Yes From activity page, press Use a preset Select Journal , press Use this preset Add an entry to the activity View the entry Expand the Comments section Confirm the expand/collapse icon updates correctly Confirm the loading icon is appropriately sized Add a comment Confirm the loading icon is shown again Collapse the Comments section Confirm the expand/collapse icon updates correctly
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-83940~~ using repository: https://github.com/paulholden/moodle/

MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83940-404 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/1), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83940-405 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/1), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

main (0 errors / 1 warnings) [branch: MDL-83940 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/1), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Wed 11 Dec 2024 09:46:53 AM UTC
Show
Code verified against automated checks with warnings. Checked MDL-83940 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-83940-404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/1) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-83940-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/1) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (0 errors / 1 warnings) [branch: MDL-83940 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/1) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Wed 11 Dec 2024 09:46:53 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83940~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17662/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60170/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60171/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83940~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17663/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60172/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60173/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83940~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17664/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60174/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60175/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60176/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60177/ App tests (stable app version)

Built on: Mon Dec 9 10:25:43 AM UTC 2024
Show
Launching automatic jobs for branch MDL-83940 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17662/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60170/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60171/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83940 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17663/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60172/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60173/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83940 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17664/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60174/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60175/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60176/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60177/ App tests (stable app version) Built on: Mon Dec 9 10:25:43 AM UTC 2024

Observe:

The collapse/expand icons are not updated as you toggle the column area (not sure where this was broken);
The loading icon is massive (regression from ~~MDL-82497~~)

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Comments.gif
111 kB
06/Dec/24 6:49 PM
MDL-83940.gif
260 kB
19/Dec/24 12:56 PM

is a regression caused by

MDL-82497 Update icon_map with the latest icons from Font Awesome 6 (core)

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Huong Nguyen, Paul Holden, Ron Carl Alfon Yu, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 06/Dec/24 6:43 PM

Updated:: 19/Dec/24 8:27 PM

Resolved:: 19/Dec/24 8:27 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 4m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify