Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.2
Affects Version/s: 4.5 regressions, 4.5.1
Component/s: Course, Themes
Labels:
- ci
- regression
- release_notes
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.5 Branch:
~~MDL-83956~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83956-405
Pull Main Branch:
~~MDL-83956~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83956
Testing Instructions:
Hide

Log in as admin

Navigate to Courses > Manage courses and categories in site administration

Create sub-categories multi-levels deep

Confirm that each category does not have an empty square image next to it (preserve 4.4 behaviour)
Show
Log in as admin Navigate to Courses > Manage courses and categories in site administration Create sub-categories multi-levels deep Confirm that each category does not have an empty square image next to it (preserve 4.4 behaviour)
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83956~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83956-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83956 | CI Job]

_{More information about this report}

Built on: Wed 11 Dec 2024 09:27:15 AM UTC
Show
Code verified against automated checks. Checked MDL-83956 using repository: https://github.com/paulholden/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83956-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83956 | CI Job ] More information about this report Built on: Wed 11 Dec 2024 09:27:15 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83956~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17666/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60182/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60183/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83956~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17667/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60184/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60185/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60186/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60187/ App tests (stable app version)

Built on: Mon Dec 9 12:25:52 UTC 2024
Show
Launching automatic jobs for branch MDL-83956 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17666/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60182/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60183/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83956 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17667/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60184/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60185/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60186/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60187/ App tests (stable app version) Built on: Mon Dec 9 12:25:52 UTC 2024

This was noticed by davidcarrillo when we was still upset about missing out on blueberry pancakes (as you can imagine, this sent him over the edge)

In ~~MDL-82497~~ (specifically here) the 'i/empty' icon mapping was changed from a FA spacer image to the outline of a square - which leads to the following in the course & category management page - where we have a very confusing "double checkbox" effect for each category in the tree (the latter being an image of a square outline):

We should fix this, before davidcarrillo misses out on his blueberry pancakes again

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-83956.png
259 kB
19/Dec/24 1:15 PM
MDL-83956-aligned.png
192 kB
10/Dec/24 1:10 AM
Screenshot 2024-12-09 at 08-59-32 Course and category management Moodle Master.png
22 kB
09/Dec/24 4:59 PM

has a non-specific relationship to

MDL-84774 Icon not displayed

Closed

is a regression caused by

MDL-82497 Update icon_map with the latest icons from Font Awesome 6 (core)

Closed

is duplicated by

MDL-84134 Placeholder icon shown in "Manage course categories and courses"

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Huong Nguyen, Luca Bösch, Paul Holden, Ron Carl Alfon Yu, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 10 Start watching this issue

Created:: 09/Dec/24 4:54 PM

Updated:: 07/Mar/25 8:04 PM

Resolved:: 19/Dec/24 8:26 PM

Estimated:

Not Specified

Remaining:

Logged:

44m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify