Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.5.2
Affects Version/s: 4.5 regressions, 4.5.1
Component/s: Web Services
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle
Pull 4.5 Branch:
~~MDL-83959~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-83959-405
Pull Main Branch:
~~MDL-83959~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-83959
Testing Instructions:
Hide

Log in as admin

Navigate to Server > Web server > External services in site administration

Press Add

Name: My test

Shortname: <empty>

Make a note of the service ID from page URL:

/admin/webservice/service_functions.php?id=<SERVICEID>

Run the following DB query:

UPDATE m_external_services SET shortname = NULL WHERE id = <SERVICEID>

Navigate to Server > Web server > Manage tokens in site administration

Create a token for the admin user to use the My test service

Confirm you can see the new token in the Manage tokens table

Create another token for the admin user to use the Moodle mobile web service service

Copy the generated token (press Copy to clipboard)

Run the following DB query:

UPDATE m_external_tokens SET externalserviceid = <SERVICEID> WHERE token = '<TOKEN>'

Reload the Manage tokens page

Confirm you can see the updated token in the Manage tokens table

Confirm that you can delete both of the tokens you've created above
Show
Log in as admin Navigate to Server > Web server > External services in site administration Press Add Name: My test Shortname: <empty> Make a note of the service ID from page URL: /admin/webservice/service_functions.php?id=<SERVICEID> Run the following DB query: UPDATE m_external_services SET shortname = NULL WHERE id = <SERVICEID> Navigate to Server > Web server > Manage tokens in site administration Create a token for the admin user to use the My test service Confirm you can see the new token in the Manage tokens table Create another token for the admin user to use the Moodle mobile web service service Copy the generated token (press Copy to clipboard ) Run the following DB query: UPDATE m_external_tokens SET externalserviceid = <SERVICEID> WHERE token = '<TOKEN>' Reload the Manage tokens page Confirm you can see the updated token in the Manage tokens table Confirm that you can delete both of the tokens you've created above
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-83959~~ using repository: https://github.com/paulholden/moodle

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83959-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-83959 | CI Job]

_{More information about this report}

Built on: Wed Dec 18 12:57:08 PM UTC 2024
Show
Code verified against automated checks. Checked MDL-83959 using repository: https://github.com/paulholden/moodle MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83959-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83959 | CI Job ] More information about this report Built on: Wed Dec 18 12:57:08 PM UTC 2024
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-83959~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17757/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60489/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60490/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-83959~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17758/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60491/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60492/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60493/ Behat (Firefox - classic) --> known random

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60494/ App tests (stable app version)

Built on: Wed Dec 18 02:25:38 PM UTC 2024
Show
Launching automatic jobs for branch MDL-83959 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17757/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60489/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60490/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-83959 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17758/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60491/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60492/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60493/ Behat (Firefox - classic) --> known random https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60494/ App tests (stable app version) Built on: Wed Dec 18 02:25:38 PM UTC 2024

Hello

with moodle 4.5+ I have this error while opening the page to view/create new tokens under webservices. Apparently other users are experiencing the same issue. It would be great if you can provide a solution as soon as possible.

Below the error

Exception - core_webservice\reportbuilder\local\systemreports\tokens::get_missing_capabilities(): Argument #3 ($serviceshortname) must be of type string, null given, called in [dirroot]/webservice/classes/reportbuilder/local/systemreports/tokens.php on line 146

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

image-2024-12-09-13-47-22-534.png
105 kB
09/Dec/24 8:47 PM
test_MDL-83959_step_13.png
50 kB
02/Jan/25 2:52 PM
test_MDL-83959_step_5.png
4 kB
02/Jan/25 2:52 PM
token.PNG
103 kB
09/Dec/24 8:43 PM

is a regression caused by

MDL-79496 Convert manage tokens report to system report

Closed

is duplicated by

MDL-84047 Admin cannot view web service tokens after token is created by user

Closed

links to

Community forum: Error in token.php

Assignee:: Paul Holden

Reporter:: Indigita2024

Peer reviewer:: Carlos Castillo

Integrator:: Huong Nguyen

Tester:: Meirza

Participants:: Carlos Castillo, CiBoT, Huong Nguyen, Indigita2024, Meirza, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 11 Start watching this issue

Created:: 09/Dec/24 6:45 PM

Updated:: 03/Jan/25 3:48 PM

Resolved:: 03/Jan/25 3:31 PM

Estimated:

Not Specified

Remaining:

Logged:

5h 28m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify