-
Bug
-
Resolution: Fixed
-
Minor
-
4.5
-
MOODLE_405_STABLE
-
MOODLE_404_STABLE, MOODLE_405_STABLE
-
MDL-83995-404 -
MDL-83995-405 -
Setup
- Log in as admin
- Navigate to Security > Site security settings in site administration
- Enable trusted content: Yes
- Create a user
- Create a course
- Enrol test user as teacher on course
- Navigate to course Permissions page
- Remove the following capability from the teacher role:
- moodle/site:trustcontent
- Log out
Import as teacher
- Log in as test user
- Navigate to course
- Add a Glossary activity to the course
- From activity page press Import entries
- Upload First (No trust).xml
and submit form - Navigate back to course page
- Add another Glossary activity to the course
- From activity page press Import entries
- Upload Second.xml and submit form
Import as admin
- Log in as admin
- Repeat identical steps as previously performed with teacher account
Test restored glossary settings
- Execute the following query in your DB:
SELECT * FROM moodle.m_glossary_entries; - Confirm the glossary entries imported by the teacher have definitiontrust equal to 0
- Confirm the glossary entries imported by the admin have definitiontrust equal to 0, except for the concept Two (definitiontrust should be equal to 1)
Export
- Navigate to most recently imported glossary
- Press the actions menu then Export
- Press Export entries to a file
- Confirm the concept One contains the following:
<DEFINITIONTRUST>0</DEFINITIONTRUST> - Confirm the concept Two contains the following:
<DEFINITIONTRUST>1</DEFINITIONTRUST>
Setup Log in as admin Navigate to Security > Site security settings in site administration Enable trusted content: Yes Create a user Create a course Enrol test user as teacher on course Navigate to course Permissions page Remove the following capability from the teacher role: moodle/site:trustcontent Log out Import as teacher Log in as test user Navigate to course Add a Glossary activity to the course From activity page press Import entries Upload First (No trust).xml and submit form Navigate back to course page Add another Glossary activity to the course From activity page press Import entries Upload Second.xml and submit form Import as admin Log in as admin Repeat identical steps as previously performed with teacher account Test restored glossary settings Execute the following query in your DB: SELECT * FROM moodle.m_glossary_entries; Confirm the glossary entries imported by the teacher have definitiontrust equal to 0 Confirm the glossary entries imported by the admin have definitiontrust equal to 0, except for the concept Two ( definitiontrust should be equal to 1) Export Navigate to most recently imported glossary Press the actions menu then Export Press Export entries to a file Confirm the concept One contains the following: <DEFINITIONTRUST>0</DEFINITIONTRUST> Confirm the concept Two contains the following: <DEFINITIONTRUST>1</DEFINITIONTRUST> -
Code verified against automated checks. 
Checked
MDL-83995using repository: https://github.com/paulholden/moodle/
MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83995-404 | CI Job]- MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83995-405 | CI Job]
- main (0 errors / 0 warnings) [branch: MDL-83995 | CI Job]
More information about this report
Built on: Tue Jan 14 08:25:06 AM UTC 2025
Code verified against automated checks. Checked MDL-83995 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-83995-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-83995-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-83995 | CI Job ] More information about this report Built on: Tue Jan 14 08:25:06 AM UTC 2025 -
On a site with "enabletrusttext" enabled, when an admin or user with trusted content permissions, creates glossary entries, they are marked as trusted (definitiontrust set to 1).
However, when importing glossary entries, the imported entries have the definitiontrust field set to 0. This becomes problematic, especially when you're importing trusted glossary entries within the same site. The imported entries are treated as untrusted which can result in potential different behaviour (same filters not applied correctly) or loss of data when edited.
