Moodle
  1. Moodle
  2. MDL-8409

Translated strings may get lost by accident

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.7, 1.7.1
    • Fix Version/s: 1.8
    • Component/s: Language
    • Labels:
      None
    • Affected Branches:
      MOODLE_15_STABLE, MOODLE_16_STABLE, MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE
    • Rank:
      29211

      Description

      The English language pack is the referential source of strings to translate. Only those strings present in the lang/en_utf8 may be localized. There are separate locations for English language pack (which is part of standard Moodle source code repository) and other languages (own repository called "lang"). This may lead to problems.

      Imagine there are two lang pack maintainers A and B working on translation of HEAD, e.g. 1.8-dev. By an accident (or for some reason), translator B updates some strings in his 1.7 installation. Those strings which are present in 1.8-dev version and are not present in the English 1.7 version are silently removed by the script lang.php.

      Yes, translators should use HEAD (and brain . But, for example, they may want to focus on the current stable branch and give priority to the strings that are currently needed. Anyway, lang.php should never silently discard localized strings itself. So I will patch it to include these "orphaned" strings in the saved file with some notice. The file may be cleaned if it is sure the string should go away definitively.

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          Fixed in lang.php revision 1.88. I will not backport this into earlier versions as translations usually use most recent versions.

          Show
          David Mudrak added a comment - Fixed in lang.php revision 1.88. I will not backport this into earlier versions as translations usually use most recent versions.

            People

            • Assignee:
              David Mudrak
              Reporter:
              David Mudrak
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: