Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8421

Old upgrade scripts create ajax as nullable (while it should be not null)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7.1, 1.8
    • Fix Version/s: 1.7.2, 1.8
    • Component/s: JavaScript
    • Labels:
      None
    • Database:
      MySQL, PostgreSQL
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE

      Description

      In http://moodle.org/mod/forum/discuss.php?d=63907

      I've seen that in the old mysql.php and postgres.php scripts, in the 1.6 => 1.7 migration, the course->ajax field is created without specifying the NOT NULL clause, so it's created as NULL (while in old *.sql and in new install.xml the description is correct).

      Also, not that the user->mailformat presents the same behaviour in Robert's DB, but I haven't been able to find anything wrong in Moodle with that field (it's created since the beginning and never upgraded in *.php scripts).

      Although it's not critical (everything works ok because the field has one meaningful default I'd modify the old *.php scripts to be 100% correct. Both 17_STABLE and HEAD.

        Attachments

          Activity

            People

            Assignee:
            stronk7 Eloy Lafuente (stronk7)
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Tester:
            Nobody
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              30/Mar/07