Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.4.5, 4.5.1
Component/s: Authentication
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.4 Branch:
~~MDL-84275~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-84275-404
Pull 4.5 Branch:
~~MDL-84275~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-84275-405
Pull Main Branch:
~~MDL-84275~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-84275
Testing Instructions:
Hide

Log in as admin

Navigate to Plugins > Filters > Manage filters in site administration

Enable Multi-language content and set Apply to: Content and headings

Navigate to General > Site home settings

Set Full site name to the following:

Moodle Master (EN)Moodle Master (DE)

Navigate to Plugins > Admin tools > Manage multi-factor authentication

Select MFA plugin enabled and save

Enable the Authenticator app factor

Navigate to Preferences from user menu

Press Multi-factor authentication preferences

Press Set up

Press Or enter details manually

Confirm the Account value is equal to "Moodle Master (EN) (admin)"
Show
Log in as admin Navigate to Plugins > Filters > Manage filters in site administration Enable Multi-language content and set Apply to: Content and headings Navigate to General > Site home settings Set Full site name to the following: Moodle Master (EN)Moodle Master (DE) Navigate to Plugins > Admin tools > Manage multi-factor authentication Select MFA plugin enabled and save Enable the Authenticator app factor Navigate to Preferences from user menu Press Multi-factor authentication preferences Press Set up Press Or enter details manually Confirm the Account value is equal to "Moodle Master (EN) (admin)"
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84275~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84275-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84275-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84275 | CI Job]

_{More information about this report}

Built on: Wed Jan 22 09:24:13 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-84275 using repository: https://github.com/paulholden/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84275-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84275-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84275 | CI Job ] More information about this report Built on: Wed Jan 22 09:24:13 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84275~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18010/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61534/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61535/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84275~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18011/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61536/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61537/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-84275~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18012/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61538/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61539/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61540/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61541/ App tests (stable app version)

Built on: Wed Jan 22 05:06:32 AM UTC 2025
Show
Launching automatic jobs for branch MDL-84275 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18010/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61534/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61535/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84275 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18011/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61536/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61537/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-84275 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18012/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61538/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61539/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61540/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61541/ App tests (stable app version) Built on: Wed Jan 22 05:06:32 AM UTC 2025

When enabling and configuring the Authenticator app MFA plugin, for sites using multilanguage formatted site name, the QR code is a noisy mess because the value is not correctly formatted:

Note the unformatted site name is also incorrectly formatted under the Or enter details manually heading too

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 13 Passed -- (Main)MDL-84275.png
68 kB
30/Jan/25 2:14 PM
Screenshot 2025-01-21 at 21-28-36 Set up factor Docker.png
60 kB
22/Jan/25 5:38 AM

has been marked as being related by

MDL-81082 MFA tool contains incorrectly formatted site name in email link

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Andrew Lyons

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Huong Nguyen, Kim Jared Lucas, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 22/Jan/25 5:32 AM

Updated:: 04/Feb/25 1:57 PM

Resolved:: 31/Jan/25 10:47 AM

Estimated:

Not Specified

Remaining:

Logged:

20m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify