Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.4.5, 4.5.1
Component/s: Badges
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
OBv3.0
Pull from Repository:
https://github.com/sarjona/moodle.git
Pull 4.4 Branch:
~~MDL-84323~~-404
Pull 4.4 Diff URL:
https://github.com/sarjona/moodle/compare/c5d94d21f2...MDL-84323-404?w=1
Pull 4.5 Branch:
~~MDL-84323~~-405
Pull 4.5 Diff URL:
https://github.com/sarjona/moodle/compare/77692ee5ea...MDL-84323-405?w=1
Pull Main Branch:
~~MDL-84323~~-main
Pull Main Diff URL:
https://github.com/sarjona/moodle/compare/bcf06a0484...MDL-84323-main?w=1
Testing Instructions:
Hide

Requirements

Public URL (using ngrok or similar).

Setup

Login as admin.

Create a site badge with endorsement and enable it:

Add a new badge filling in the mandatory fields.

Add at least one criterion.

Go to the Endorsement section and fill in the mandatory fields.

Enable access to the badge.

Award the badge to one user (it can also be awarded to the admin).

Annotate the badge id.

Testing scenario 1

Go to the user profile and download the badge.

Upload the badge to https://badgecheck.io/ and click the Verify button.

Check the badge is valid and passes all verification checks.

Testing scenario 2

In a browser (preferably Firefox), open the following URL, replacing [BADGEID] with the badge identifier you annotated in step #4 in Setup: [YOURMOODLESITE]/badges/badge_json.php?id=[BADGEID]

Check "endorsement" is not displayed in this JSON file.
Show
Requirements Public URL (using ngrok or similar). Setup Login as admin. Create a site badge with endorsement and enable it: Add a new badge filling in the mandatory fields. Add at least one criterion. Go to the Endorsement section and fill in the mandatory fields. Enable access to the badge. Award the badge to one user (it can also be awarded to the admin). Annotate the badge id. Testing scenario 1 Go to the user profile and download the badge. Upload the badge to https://badgecheck.io/ and click the Verify button. Check the badge is valid and passes all verification checks. Testing scenario 2 In a browser (preferably Firefox), open the following URL, replacing [BADGEID] with the badge identifier you annotated in step #4 in Setup: [YOURMOODLESITE] /badges/badge_json.php?id= [BADGEID] Check "endorsement" is not displayed in this JSON file.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84323~~ using repository: https://github.com/sarjona/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84323-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84323-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84323-main | CI Job]

_{More information about this report}

Built on: Fri Jan 24 02:58:14 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-84323 using repository: https://github.com/sarjona/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84323-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84323-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84323-main | CI Job ] More information about this report Built on: Fri Jan 24 02:58:14 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84323~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18077/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61760/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61761/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61762/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84323~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18078/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61763/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61764/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61765/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84323~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18079/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61766/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61767/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61768/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61769/ App tests (stable app version) / complete)

Built on: Mon Jan 27 11:53:33 AM UTC 2025
Show
Launching automatic jobs for branch MDL-84323 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18077/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61760/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61761/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61762/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84323 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18078/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61763/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61764/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61765/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84323 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18079/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61766/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61767/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61768/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61769/ App tests (stable app version) / complete) Built on: Mon Jan 27 11:53:33 AM UTC 2025

Story Points:
1
Sprint:
HQ 2025 Planning I1 Moppies

While working on MDL-83905, reviewing the BadgeClass specification for OBv2.0, I realised endorsement shouldn't be included in there.

Endorsement should be removed from the BadgeClass JSON everywhere because, when it's present, it's causing an "Invalid request" error.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 3 Passed -- (Main)MDL-84323.png
168 kB
30/Jan/25 3:56 PM
(2) 2 Passed -- (Main)MDL-84323.png
87 kB
30/Jan/25 3:56 PM
Badge_1_withendorsement.png
863 kB
24/Jan/25 10:43 PM
Badge_1_withoutendorsement.png
862 kB
24/Jan/25 10:43 PM
MDL-84323_invalid.png
93 kB
24/Jan/25 10:43 PM
MDL-84323_valid.png
201 kB
24/Jan/25 10:43 PM

Assignee:: Sara Arjona (@sarjona)

Reporter:: Sara Arjona (@sarjona)

Peer reviewer:: Ferran Recio

Integrator:: Amaia Anabitarte

Tester:: Kim Jared Lucas

Participants:: Amaia Anabitarte, CiBoT, Ferran Recio, Huong Nguyen, Kim Jared Lucas, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 24/Jan/25 7:31 PM

Updated:: 03/Feb/25 7:00 PM

Resolved:: 31/Jan/25 10:47 AM

Estimated:

Not Specified

Remaining:

Logged:

2h 35m

Details

Requirements

Setup

Testing scenario 1

Testing scenario 2

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify