Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 4.5
Component/s: Language
Labels:
- ci
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull 4.4 Branch:
~~MDL-84538~~-M404_fix-duplicated-language-strings
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...ziegenberg:MDL-84538-M404_fix-duplicated-language-strings
Pull 4.5 Branch:
~~MDL-84538~~-M405_fix-duplicated-language-strings
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...ziegenberg:MDL-84538-M405_fix-duplicated-language-strings
Pull Main Branch:
~~MDL-84538~~_fix-duplicated-language-strings
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-84538_fix-duplicated-language-strings
Testing Instructions:
Hide

Setup

Ensure you have the codechecker plugin in your moodle "/local" dir.

Ensure the plugin dependencies are up-to-date: composer update

Testing

Run phpcs against the moodle.PHPUnit.TestCaseProvider sniff:

phpcs --warning-severity=0 --sniffs=moodle.Files.LangFilesOrdering .

Confirm no errors related to the following:

The string key "X" is duplicated

Please note: phpcs is located in local/codechecker/vendor/bin, so alternatively you can run the command:

local/codechecker/vendor/bin/phpcs --warning-severity=0 --sniffs=moodle.Files.LangFilesOrdering .
Show
Setup Ensure you have the codechecker plugin in your moodle "/local" dir. Ensure the plugin dependencies are up-to-date: composer update Testing Run phpcs against the moodle.PHPUnit.TestCaseProvider sniff: phpcs --warning-severity=0 --sniffs=moodle.Files.LangFilesOrdering . Confirm no errors related to the following: The string key "X" is duplicated Please note: phpcs is located in local/codechecker/vendor/bin , so alternatively you can run the command: local/codechecker/vendor/bin/phpcs --warning-severity=0 --sniffs=moodle.Files.LangFilesOrdering .
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-84538~~ using repository: https://github.com/ziegenberg/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84538-M404_fix-duplicated-language-strings | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84538-M405_fix-duplicated-language-strings | CI Job]

main (0 errors / 0 warnings) [branch: MDL-84538_fix-duplicated-language-strings | CI Job]

_{More information about this report}

Built on: Wed Mar 19 15:31:11 UTC 2025
Show
Code verified against automated checks. Checked MDL-84538 using repository: https://github.com/ziegenberg/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-84538-M404_fix-duplicated-language-strings | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-84538-M405_fix-duplicated-language-strings | CI Job ] main (0 errors / 0 warnings) [branch: MDL-84538_fix-duplicated-language-strings | CI Job ] More information about this report Built on: Wed Mar 19 15:31:11 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-84538~~-M404_fix-duplicated-language-strings

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63844/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63845/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63846/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84538~~-M405_fix-duplicated-language-strings

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63847/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63848/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63849/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-84538~~_fix-duplicated-language-strings

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63850/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63851/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63852/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63853/ App tests (stable app version) / complete)

Built on: Tue Mar 18 07:26:57 UTC 2025
Show
Launching automatic jobs for branch MDL-84538 -M404_fix-duplicated-language-strings https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63844/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63845/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63846/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84538 -M405_fix-duplicated-language-strings https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63847/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63848/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63849/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-84538 _fix-duplicated-language-strings https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63850/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63851/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63852/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63853/ App tests (stable app version) / complete) Built on: Tue Mar 18 07:26:57 UTC 2025

Following the discussion in ~~MDL-76565~~, I ran phpcs with the moodle.Files.LangFilesOrdering sniff across the whole code base and found some duplicated lang strings all over the place. They should be inspected and potentially fixed.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 2 Passed -- (Main)MDL-84538.png
19 kB
21/Mar/25 10:45 AM

Discovered while testing

MDL-76565 Remove strings deprecated in Moodle versions <= 4.4

Closed

Assignee:: Daniel Ziegenberg

Reporter:: Daniel Ziegenberg

Peer reviewer:: Michael Aherne

Integrator:: Paul Holden

Tester:: Kim Jared Lucas

Participants:: CiBoT, Daniel Ziegenberg, Kim Jared Lucas, Michael Aherne, Paul Holden, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 14/Feb/25 9:03 PM

Updated:: 4 days ago 11:25 PM

Resolved:: 4 days ago 11:25 PM

Estimated:

Not Specified

Remaining:

Logged:

43m

Details

Setup

Testing

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify