Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 4.4.8, 4.5.4
Component/s: Messages
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-85112~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-85112-404
Pull 4.5 Branch:
~~MDL-85112~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-85112-405
Testing Instructions:
1. Send a message to another user
2. Login as other user
3. Confirm you see only the unread message count, not the text "1 There are 1 unread conversations" hovering over the navigation bar
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-85112~~ using repository: https://github.com/paulholden/moodle/

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-85112-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85112-405 | CI Job]

_{More information about this report}

Built on: Fri Apr 4 16:47:16 UTC 2025
Show
Code verified against automated checks. Checked MDL-85112 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-85112-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-85112-405 | CI Job ] More information about this report Built on: Fri Apr 4 16:47:16 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-85112~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18930/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64790/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64791/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-85112~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18931/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64792/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64793/ Behat (Firefox - boost)

Built on: Fri Apr 4 18:25:17 UTC 2025
Show
Launching automatic jobs for branch MDL-85112 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18930/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64790/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64791/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-85112 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18931/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64792/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64793/ Behat (Firefox - boost) Built on: Fri Apr 4 18:25:17 UTC 2025

This is a regression from ~~MDL-84823~~ because "visually-hidden" class doesn't exist in those versions - results in the permanent display of the following message:

Replace with appropriate pre-BS5 helper class ("sr-only")

Doesn't affect main

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 3 Passed -- (Main)MDL-85112.png
38 kB
07/Apr/25 10:06 AM
Screenshot 2025-04-04 at 1.30.28 PM.png
229 kB
05/Apr/25 12:31 AM
Screenshot 2025-04-04 at 16-52-19 Notifications Administration Moodle 4.4.png
10 kB
05/Apr/25 12:04 AM

is a regression caused by

MDL-84823 Incorrect use of ARIA attributes in the notications popover and messaging drawers

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Pedro Jordao

Integrator:: Jun Pataleta

Tester:: Kim Jared Lucas

Participants:: CiBoT, Jun Pataleta, Kim Jared Lucas, Paul Holden, Pedro Jordao

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 05/Apr/25 12:02 AM

Updated:: 11/Apr/25 3:42 PM

Resolved:: 08/Apr/25 11:34 PM

Estimated:

Not Specified

Remaining:

Logged:

55m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify