Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8520

resource navigation borked by accessibility frame changes

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8, 1.9
    • Component/s: Resource
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      $CFG->frametarget alone does not work for framed resources, we should add also the js this.target= trick there

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            skodak Petr Skoda added a comment -

            fixed in cvs

            Show
            skodak Petr Skoda added a comment - fixed in cvs
            Hide
            mchurch Mike Churchward added a comment - - edited

            I think this is broken again...

            In 1.8.1, if a resource is a link to a file using a frame, then the previous and next navigation breaks.

            This is because the previous and next forms are using $CFG->frametarget, which doesn't get set if the frame being used is "_top".

            Suggest changing the navmenu function to explicitly place "target=$CFG->framename".

            Show
            mchurch Mike Churchward added a comment - - edited I think this is broken again... In 1.8.1, if a resource is a link to a file using a frame, then the previous and next navigation breaks. This is because the previous and next forms are using $CFG->frametarget, which doesn't get set if the frame being used is "_top". Suggest changing the navmenu function to explicitly place "target=$CFG->framename".
            Hide
            mchurch Mike Churchward added a comment -

            Fixed. Added a 'target=' to the forms.

            Show
            mchurch Mike Churchward added a comment - Fixed. Added a 'target=' to the forms.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  31/Mar/07