Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8629

"Immediate send" option still says you have 30 minutes to edit

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7.1, 1.8
    • Fix Version/s: 1.8
    • Component/s: Forum
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      When the "Immediate send" box is checked and "send" is clicked, the following screen says both
      "Your message will be sent immediately" AND
      "You have 30 minutes to edit this message".

      Perhaps these lines in post.php need to be modified so that the $message variable is only set if $post->mailnow is empty:

      NOW
      $message .= '<br />'.get_string("postadded", "forum", format_time($CFG->maxeditingtime));

      if ($subscribemessage = forum_post_subscription($post))

      { $timemessage = 4; }

      if (!empty($post->mailnow)) { $message .= get_string("postmailnow", "forum"); $timemessage = 4; }

      MODIFICATION

      if ($subscribemessage = forum_post_subscription($post)) { $timemessage = 4; }

      if (!empty($post->mailnow))

      { $message .= get_string("postmailnow", "forum"); $timemessage = 4; $message = ""; }

      else

      { $message .= '<br />'.get_string("postadded", "forum", format_time($CFG->maxeditingtime)); }

        Attachments

          Activity

            People

            • Assignee:
              nicolasconnault Nicolas Connault
              Reporter:
              trobb Thomas Robb
              Tester:
              Nobody
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                31/Mar/07