Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8709

Javascript: pseudo-protocol in admin tree block is bad

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8, 1.9
    • Fix Version/s: 1.8, 1.9
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      href="javascript: ..." is not a standardised protocol, and does not degrade gracefully with Javascript disabled, see:
      http://diveintoaccessibility.org/day_13_using_real_links.html
      http://lists.evolt.org/archive/Week-of-Mon-20041206/166888.html

      I'm about to commit this patch which uses <a href="#" onclick="...; return false"> – Return false is important - see here,
      http://cs.wellesley.edu/~cs110/examples/return.html

      Note, href="#" isn't ideal but it's an improvement!

        Attachments

          Activity

            People

            Assignee:
            nfreear Nick Freear
            Reporter:
            nfreear Nick Freear
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              31/Mar/07