Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8746

Fixing tabs concept...

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      This track has been created in relation to http://moodle.org/mod/forum/discuss.php?d=66136

      I think that currently all the tabs (main tabs) in Moodle are using only one row, where the second row (secondary tabs) is used to show options belonging to the selected in the first one "sub-tabbing". And visualisation has changed recently, making it more according with that "sub-tab" concept. Great!

      But... what happens with places where the "main tabs" are a bunch and need to be displayed over more than one row? There is one notable place where this is happening: Glossary module, where the second row of tabs are showed as "sub-tabs" where they are "main-tabs" conceptually.

      More yet, the new "sub-tabs" concept makes the $CFG->tabselectedtofront setting nosense at all (if I'm not wrong) breaking visualisation of glossary tabs if enabled.

      Uhm, I really think we should be able to differentiate such "main-tabs" from the "secondary-tabs" no matter the number of rows used by each one. I can imagine say, the profile page, having more and more tabs for new things in the future. Some day, we'll need to separate such "main-tabs" into more than one row and then we'll run into problems. The error is to assume than the 2nd row is a secondary row.

      Note that, as a quick solution, I've proposed to delete such setting from Moodle 1.8. But this won't solve the issue that, IMO, is to use the number of the row to sub-tab. I think we should support "main-tabs" using more than 1 row, each one having optionally some "secondary-tabs" also supporting more than one row. But the number of rows shouldn't be used to determinate the "character" (main, secondary) of the tab/row.

      Adding some people here...

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Tester:
              Nobody
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                31/Mar/07