Moodle
  1. Moodle
  2. MDL-8774

missing alert for required field

    Details

    • Affected Branches:
      MOODLE_18_STABLE

      Description

      In Moodle 1.8 I added a database activity to a course and I added a picture field to the only table.
      Going to add a record I filled the form asking for a picture path and an alternative text.
      I entered a correct path for my picture and I submitted the form.
      Moodle allowed this to me.

      Since Moodle 1.8 is strict if HAS TO require the alternative text. What I believe is that the alternative text should change to a red bordered field and an alert should appear.

        Gliffy Diagrams

        1. lib.php.patch
          3 kB
          Nicolas Connault

          Issue Links

            Activity

            Hide
            Martin Dougiamas added a comment -

            Yep, this is a good idea.

            Show
            Martin Dougiamas added a comment - Yep, this is a good idea.
            Hide
            Nicolas Connault added a comment -

            I haven't yet fixed this, I've been refactoring the whole preset thing. The issue is that the code was so badly structured that a simple refactoring wasn't an option. Consequently I got stuck into a job that will probably take a few days to complete. However, most of it is already done in mod/data/preset_new.php and mod/data/preset_class.php. The preset_new.php file is to be renamed preset.php once this all works fine, while the class is a new file entirely.

            A small patch also needs to be applied to mod/data/lib.php, as attached to this issue..

            Show
            Nicolas Connault added a comment - I haven't yet fixed this, I've been refactoring the whole preset thing. The issue is that the code was so badly structured that a simple refactoring wasn't an option. Consequently I got stuck into a job that will probably take a few days to complete. However, most of it is already done in mod/data/preset_new.php and mod/data/preset_class.php. The preset_new.php file is to be renamed preset.php once this all works fine, while the class is a new file entirely. A small patch also needs to be applied to mod/data/lib.php, as attached to this issue..
            Hide
            Nicolas Connault added a comment -

            this patch will need to be applied to mod/data/lib.php when the new Preset class is implemented (after thorough testing).

            Show
            Nicolas Connault added a comment - this patch will need to be applied to mod/data/lib.php when the new Preset class is implemented (after thorough testing).
            Hide
            Nicolas Connault added a comment -

            Ok this issue actually needs the mod/data/edit.php page to be converted to mform... how annoying, but it must be done.

            Show
            Nicolas Connault added a comment - Ok this issue actually needs the mod/data/edit.php page to be converted to mform... how annoying, but it must be done.
            Hide
            Nicolas Connault added a comment -

            This issue isn't that important to fix right now:
            Martin: "Data entered is not really our problem, it would be nice to restrict it but it doesn't affect the strictness of moodle itself."

            Show
            Nicolas Connault added a comment - This issue isn't that important to fix right now: Martin: "Data entered is not really our problem, it would be nice to restrict it but it doesn't affect the strictness of moodle itself."
            Hide
            Eloy Lafuente (stronk7) added a comment -

            NOTE: This issue was assigned to the STABLE backlog without complete triaging process. Marking it as triaged, but with this note for future reference.

            Show
            Eloy Lafuente (stronk7) added a comment - NOTE: This issue was assigned to the STABLE backlog without complete triaging process. Marking it as triaged, but with this note for future reference.
            Hide
            Michael de Raadt added a comment -

            Thanks for reporting this issue.

            We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

            If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

            Michael d.

            TW9vZGxlDQo=

            Show
            Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
            Hide
            Michael de Raadt added a comment -

            I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

            This is being done as part of a bulk annual clean-up of issues.

            If you still believe this is an issue in supported versions, please create a new issue.

            Show
            Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: