Moodle
  1. Moodle
  2. MDL-8984

multimedia plugin should be able to detect swf file's original size and show it on page

    Details

    • Type: Improvement Improvement
    • Status: Reopened
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.6, 1.7, 1.8
    • Fix Version/s: None
    • Component/s: Filters
    • Labels:
      None
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE
    • Rank:
      3524

      Description

      multimedia plugin should be able to detect swf file's original size and show it on webpage, that will be much better and useable. But now the swf file are shown in a very small box, students can not even see the words in the flash movie.

        Activity

        Hide
        Petr Škoda added a comment -

        AFAIK you can not detect the visual size of swf file
        But you can specifiy the size of swf in url by d=widthxheight parameter

        In any case the automatic embedding of swf is strongly discouraged due to security concerns, I would not advise it for any production site.

        Show
        Petr Škoda added a comment - AFAIK you can not detect the visual size of swf file But you can specifiy the size of swf in url by d=widthxheight parameter In any case the automatic embedding of swf is strongly discouraged due to security concerns, I would not advise it for any production site.
        Hide
        michael p added a comment -

        Perhaps I'm not understanding the issue, but I believe it is possible to detect the dimensions of a flash file on the server using PHP, as in http://radcom.ir/weblog/amir/archive/2006/07/03/29155.aspx

        Show
        michael p added a comment - Perhaps I'm not understanding the issue, but I believe it is possible to detect the dimensions of a flash file on the server using PHP, as in http://radcom.ir/weblog/amir/archive/2006/07/03/29155.aspx
        Hide
        Petr Škoda added a comment -

        Thanks for the info!
        It is possible, but still it would require native PHP swf parser and we could not do the detection on the fly (performance problems with large files) and in the end it would not be recommended for use on production sites

        Show
        Petr Škoda added a comment - Thanks for the info! It is possible, but still it would require native PHP swf parser and we could not do the detection on the fly (performance problems with large files) and in the end it would not be recommended for use on production sites
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Just one link I had in my collection:

        http://www.expertsrt.com/articles/VGR/SWF-Frame-Rate-Extraction.html
        (with the php extractor here: http://www.expertsrt.com/articles/VGR/files/swfheader.class.txt)

        Ciao

        P.S.: Perhaps is could be considered an extra feature of the multimedia filter, configurable from admin filter interface? I would change it from won't fix to, say, 1.9....

        Show
        Eloy Lafuente (stronk7) added a comment - Just one link I had in my collection: http://www.expertsrt.com/articles/VGR/SWF-Frame-Rate-Extraction.html (with the php extractor here: http://www.expertsrt.com/articles/VGR/files/swfheader.class.txt ) Ciao P.S.: Perhaps is could be considered an extra feature of the multimedia filter, configurable from admin filter interface? I would change it from won't fix to, say, 1.9....
        Hide
        Petr Škoda added a comment -

        ok, reopening and assigning to Eloy

        The only thing I do not understand is why spend time on implementing function that should not be used? (because it is dangerous to embed arbitrary flash files that can be full of dirty javascript code). I agree that it might be fine to use this code in resource mod where we can trust the files submitted by teachers.

        Show
        Petr Škoda added a comment - ok, reopening and assigning to Eloy The only thing I do not understand is why spend time on implementing function that should not be used? (because it is dangerous to embed arbitrary flash files that can be full of dirty javascript code). I agree that it might be fine to use this code in resource mod where we can trust the files submitted by teachers.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Hot Potato for Martin Dougiamas... :-D

        please, decide if this feature should be into code, in the filter, configurable, applied to what versions and for all contents.... sounds simple! :-P

        I just was adding one reference and proposing one solution, Petr, but if it has increased security implications -1 for it. Else I would maintain my +1 for > 1.8.

        Show
        Eloy Lafuente (stronk7) added a comment - Hot Potato for Martin Dougiamas... :-D please, decide if this feature should be into code, in the filter, configurable, applied to what versions and for all contents.... sounds simple! :-P I just was adding one reference and proposing one solution, Petr, but if it has increased security implications -1 for it. Else I would maintain my +1 for > 1.8.
        Hide
        Petr Škoda added a comment -

        My +1 to use new html editor (fckeditor anyone?) and add this into "Insert flash button"
        My +1 for automatic sizing in resource module embedding

        My -1 for implementing in media filter - slow + insecure anyway

        Show
        Petr Škoda added a comment - My +1 to use new html editor (fckeditor anyone?) and add this into "Insert flash button" My +1 for automatic sizing in resource module embedding My -1 for implementing in media filter - slow + insecure anyway

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: