Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8984

multimedia plugin should be able to detect swf file's original size and show it on page

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Inactive
    • Affects Version/s: 1.6, 1.7, 1.8
    • Fix Version/s: None
    • Component/s: Filters
    • Labels:
      None
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE

      Description

      multimedia plugin should be able to detect swf file's original size and show it on webpage, that will be much better and useable. But now the swf file are shown in a very small box, students can not even see the words in the flash movie.

        Gliffy Diagrams

          Activity

          Hide
          skodak Petr Skoda added a comment -

          AFAIK you can not detect the visual size of swf file
          But you can specifiy the size of swf in url by d=widthxheight parameter

          In any case the automatic embedding of swf is strongly discouraged due to security concerns, I would not advise it for any production site.

          Show
          skodak Petr Skoda added a comment - AFAIK you can not detect the visual size of swf file But you can specifiy the size of swf in url by d=widthxheight parameter In any case the automatic embedding of swf is strongly discouraged due to security concerns, I would not advise it for any production site.
          Hide
          ortsaipekim michael p added a comment -

          Perhaps I'm not understanding the issue, but I believe it is possible to detect the dimensions of a flash file on the server using PHP, as in http://radcom.ir/weblog/amir/archive/2006/07/03/29155.aspx

          Show
          ortsaipekim michael p added a comment - Perhaps I'm not understanding the issue, but I believe it is possible to detect the dimensions of a flash file on the server using PHP, as in http://radcom.ir/weblog/amir/archive/2006/07/03/29155.aspx
          Hide
          skodak Petr Skoda added a comment -

          Thanks for the info!
          It is possible, but still it would require native PHP swf parser and we could not do the detection on the fly (performance problems with large files) and in the end it would not be recommended for use on production sites

          Show
          skodak Petr Skoda added a comment - Thanks for the info! It is possible, but still it would require native PHP swf parser and we could not do the detection on the fly (performance problems with large files) and in the end it would not be recommended for use on production sites
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Just one link I had in my collection:

          http://www.expertsrt.com/articles/VGR/SWF-Frame-Rate-Extraction.html
          (with the php extractor here: http://www.expertsrt.com/articles/VGR/files/swfheader.class.txt)

          Ciao

          P.S.: Perhaps is could be considered an extra feature of the multimedia filter, configurable from admin filter interface? I would change it from won't fix to, say, 1.9....

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Just one link I had in my collection: http://www.expertsrt.com/articles/VGR/SWF-Frame-Rate-Extraction.html (with the php extractor here: http://www.expertsrt.com/articles/VGR/files/swfheader.class.txt ) Ciao P.S.: Perhaps is could be considered an extra feature of the multimedia filter, configurable from admin filter interface? I would change it from won't fix to, say, 1.9....
          Hide
          skodak Petr Skoda added a comment -

          ok, reopening and assigning to Eloy

          The only thing I do not understand is why spend time on implementing function that should not be used? (because it is dangerous to embed arbitrary flash files that can be full of dirty javascript code). I agree that it might be fine to use this code in resource mod where we can trust the files submitted by teachers.

          Show
          skodak Petr Skoda added a comment - ok, reopening and assigning to Eloy The only thing I do not understand is why spend time on implementing function that should not be used? (because it is dangerous to embed arbitrary flash files that can be full of dirty javascript code). I agree that it might be fine to use this code in resource mod where we can trust the files submitted by teachers.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Hot Potato for Martin Dougiamas... :-D

          please, decide if this feature should be into code, in the filter, configurable, applied to what versions and for all contents.... sounds simple! :-P

          I just was adding one reference and proposing one solution, Petr, but if it has increased security implications -1 for it. Else I would maintain my +1 for > 1.8.

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Hot Potato for Martin Dougiamas... :-D please, decide if this feature should be into code, in the filter, configurable, applied to what versions and for all contents.... sounds simple! :-P I just was adding one reference and proposing one solution, Petr, but if it has increased security implications -1 for it. Else I would maintain my +1 for > 1.8.
          Hide
          skodak Petr Skoda added a comment -

          My +1 to use new html editor (fckeditor anyone?) and add this into "Insert flash button"
          My +1 for automatic sizing in resource module embedding

          My -1 for implementing in media filter - slow + insecure anyway

          Show
          skodak Petr Skoda added a comment - My +1 to use new html editor (fckeditor anyone?) and add this into "Insert flash button" My +1 for automatic sizing in resource module embedding My -1 for implementing in media filter - slow + insecure anyway
          Hide
          marina Marina Glancy added a comment -

          We have detected that this issue has been inactive for over two years and also did not collect many votes. It is possible that it has been already implemented in a more recent version of Moodle, or it is not highly demanded. There are unlimited number of ways Moodle functinality can be expanded and improved but we would like to concentrate on the features that will benefit majority of users, and which can not be implemented as plugins. If you have a suggestion for improving Moodle core, and there is no open issue for it in the tracker, please start a new forum discussion to see how many other users agree with you, and then create a new issue providing as many details as possible.

          ==BLK2YIMP20141121==

          Show
          marina Marina Glancy added a comment - We have detected that this issue has been inactive for over two years and also did not collect many votes. It is possible that it has been already implemented in a more recent version of Moodle, or it is not highly demanded. There are unlimited number of ways Moodle functinality can be expanded and improved but we would like to concentrate on the features that will benefit majority of users, and which can not be implemented as plugins. If you have a suggestion for improving Moodle core, and there is no open issue for it in the tracker, please start a new forum discussion to see how many other users agree with you, and then create a new issue providing as many details as possible. ==BLK2YIMP20141121==

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: