Moodle
  1. Moodle
  2. MDL-8990

regrade not considering responses given on last attempt

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.4, 1.7.1
    • Fix Version/s: 1.6.6, 1.7.2, 1.8, 1.9
    • Component/s: Questions, Quiz
    • Labels:
      None
    • Environment:
      All
    • Database:
      Any
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      28954

      Description

      Problem:
      It was observed on a quiz using multiple attempts with build on last, no adaptative (but suitable to be observed in other cases too).

      As an example, imagine that on the 1st attempt, student answers question 1 2 3 leaving 4 5 6 clear. On 2nd attempt, the previous values are filled in
      and the students answers question 5. Everithing gets correctly graded, values on DB are OK.

      Then, without altering none of the questions, the teacher hits regrade tab, 2nd attempt only considers only question five 5 while grading,
      reseting results (grade, raw_grade, ..) out of 1 2 3, but strangely the answers are still there.

      Solution:
      Fix unchanged responses decision's code on question_process_responses() from lib/questionlib.php (backported from v1.8)

        Issue Links

          Activity

          Hide
          Paulo Matos added a comment -

          The patch with backported fix from 1.8 branch.

          Show
          Paulo Matos added a comment - The patch with backported fix from 1.8 branch.
          Hide
          Paulo Matos added a comment -

          This has been partially described on discussion referred on MDL-6269.

          Show
          Paulo Matos added a comment - This has been partially described on discussion referred on MDL-6269 .
          Hide
          Paulo Matos added a comment -

          Several tests have been done with several quizzes with a mixed set of questiontypes and without/with changes on questions from right to wrong
          and reverting the changes always observing regrade results as expected.

          Show
          Paulo Matos added a comment - Several tests have been done with several quizzes with a mixed set of questiontypes and without/with changes on questions from right to wrong and reverting the changes always observing regrade results as expected.
          Hide
          Tim Hunt added a comment -

          I hope the check the fix into 1.6.4+ tomorrow, but it needs more testing.

          Show
          Tim Hunt added a comment - I hope the check the fix into 1.6.4+ tomorrow, but it needs more testing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: