Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-9021

View of html resource not adds in log in certain conditions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.4, 1.6.5, 1.7, 1.7.1, 1.7.2, 1.8, 1.9, 2.0
    • Fix Version/s: 1.7.2, 1.8, 1.9
    • Component/s: Resource
    • Labels:
      None
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      I talk about the display function in the resource_html class definition ( mod/resource/type/html/resource.class.php )

      I think it miss a call of the add_to_log function when $resource->popup is true and $inpopup is false.

      In any case I think that this function must be call one time, before the first "if" and why not, in the parent::display function ,

      Are you agree ?

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  30/Mar/07