Glossary printer-friendly view does not work for uncategorised entry view

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Confirmed still occurs in current master.

Code change looks fine. Could you add a brief description of what the problem actually was and why this change fixes it.

This looks like it will require versions for 2.2 and 2.1.

It also needs testing instructions.

What happened is that the uncategorised entry is identified by '-1', but the dash was filtered by optional_param(), and therefore the category was incorrect. I used the same cleaning parameter than on the other pages to fix this.

I have created the branches for 2.1 and 2.2 and wrote the test instructions. I should have done that in the first place.

Thanks!

You are go for integration

Hi Fredm

In general we shouldn't be converting to use PARAM_CLEAN as its marked deprecated and does a generic cleaning and probably isn't that safe.

I had a look around and I can't for the life of me understand what the hook parameter it supposed to be, and in fact its not consistent:

approve.php:$hook = optional_param('hook', 'ALL', PARAM_CLEAN);
deleteentry.php:$hook     = optional_param('hook', '', PARAM_CLEAN);
editcategories.php:$hook   = optional_param('hook', '', PARAM_ALPHANUM); // category ID
export.php:$hook= optional_param('hook', '', PARAM_CLEAN);           // the term, entry, cat, etc... to look for based on mode
exportentry.php:$hook     = optional_param('hook', '', PARAM_CLEAN);
import.php:$hook     = optional_param('hook', 'ALL', PARAM_ALPHANUM);
lib.php:    $hook = optional_param('hook', 'ALL', PARAM_CLEAN);
print.php:$hook    = optional_param('hook','ALL', PARAM_ALPHANUM);   // what to show
view.php:$hook       = optional_param('hook', '', PARAM_CLEAN);           // the term, entry, cat, etc... to look for based on mode
view.php:$show       = optional_param('show', '', PARAM_ALPHA);           // [ concept | alias ] => mode=term hook=$show

So, i'm not really keen on this solution. Should it in fact be PARAM_INT? Or what other values can hook be?

Well, PARAM_INT would be the best idea except that hook can contain letters too, like 'all'. This parameter contains different type of data from one place to another in the glossary. I did not pay attention to the fact that PARAM_CLEAN was deprecated, but having a look at clean_param() now, I guess PARAM_ALPHANUMEXT would be good.

OK, well i'm going to reopen this if you could took at that, thanks

(Note the real solution should be for that crazy parameter to use individual params for different things, but..)

There are the updated patches!

I accidentally reopened this issue. Sorry!

Submit for integration

The hook is first letter of the concept (unicode char), or a hardcoded constant - that means both current code (PARAM_ALPHANUM) and the patch (PARAM_ALPHANUMEXT) are not correct. There is no simple way to clean it, it might be best to whitelist those special words and use s() and p() for page output.

Petr. How about we go one step closer to fixing this problem by accepting this incremental patch, then create a new issue for the utf8 problem?

(that sucks, but it already sucks anyway so is at least an improvement).

hmm, if you want a hacky patch then use PARAM_CLEAN, it is already used in other glossary scripts, the PARAM_ALPHA* is wrong

There I have updated the branchs with the hack. I guess we should create a new issue to have a correct sanitization of the params.

Raise a new MDL for the additional work and link it to this one. Submit for integration when you're ready.

Integrated to master, 23, 22 and 21 - thanks.

Tested on integration 2.1, 2.2 and 2.3 and passes in all the branches. Thanks Fred for the detailed steps to test

PD: I pick that one cause I've begun testing before the SCRUM (it's the first one ordering by KEY)

Congratulations your code is upstream - gold star for you!

This issue + 79 others made it in in time for the minor releases.
Thank you everyone involved for your exuberant efforts.