Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-9083

JavaScript nodeName returns in lower case now

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8
    • Component/s: Libraries
    • Labels:
      None
    • Environment:
      FireFox 2.0.0.3
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      Best example is clicking on the Hide/Show icon for blocks. When I do this I get a "el has no properties" for this line:

      while(el.nodeName != 'BODY') {

      This is in the findParentNode() method in the lib/javascript-static.js file.

      I found that the el.nodeName returns the node name in lower case instead of all caps. I made a quick fix for this for the findParentNode() (see attached), but perhaps more investigations are needed for a more permanent and long term solution (EG: what other browsers return for .nodeName and other code that needs to be updated, etc).

        Attachments

          Activity

            People

            • Assignee:
              bushido Mark Nielsen
              Reporter:
              bushido Mark Nielsen
              Tester:
              Nobody
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                31/Mar/07