Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-9087

When student places table inside Online assignment the "Edit my submission" button disapears

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.2, 1.6.3, 1.6.4, 1.7, 1.7.1, 1.8
    • Fix Version/s: 1.8, 1.9
    • Component/s: Assignment (2.2), Other
    • Labels:
      None
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      If a student puts a table inside their online assignment submission, they can no longer see the edit my submissions button because it invalidates the html on the page.

      • to fix the problem, in the function view() of mod\assignment\type\online\assignment.class.php

      the function print_simple_box_end(); should be called before displaying the edit button, and after it, to display the edit my submissions box - something like this would work:

      if (!$editmode && $editable)

      { echo "<div align='center'>"; print_single_button('view.php', array('id'=>$this->cm->id,'edit'=>'1'), get_string('editmysubmission', 'assignment')); echo "</div>"; }

      Of course this doesn't fix the problem with the page not being valid xhtml - but it still allows the student to use the page!

      Dan

        Gliffy Diagrams

          Activity

          Hide
          danmarsden Dan Marsden added a comment -

          fix now in 18_stable and HEAD (with xhtml strict compliant patch!)

          Show
          danmarsden Dan Marsden added a comment - fix now in 18_stable and HEAD (with xhtml strict compliant patch!)

            People

            • Assignee:
              danmarsden Dan Marsden
              Reporter:
              danmarsden Dan Marsden
              Tester:
              Nobody
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                31/Mar/07