Moodle
  1. Moodle
  2. MDL-9187

Weekly View Doesn't Show Hyphen Between Date Range

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8.1, 1.9
    • Component/s: Course
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      29650

      Description

      I think this may be a problem with the "standard" theme.

      I've included 2 screenshots taken while using the standard theme.

      1,. Left side shows that no hyphens are between the dates in "Weekly" mode.
      2. The right side shows that they show using the "Weekly CSS/No Tables" mode.

      You'll notice that there is an additional problem, with the CSS one, if blocks are wider than expected. (However, I assume that this behavious is expected.)

      Macintosh Safari
      Moodel 1.8
      American English Language Pack

        Activity

        Hide
        Charles Kelly added a comment -

        Note it's not a "theme" problem.

        This is how I fixed it on my local copy of Moodle 1.8

        This is the file that I changed:
        course/format/weeks/format.php

        I changed line 214 from:
        $weekperiod = $weekday.' '.$endweekday;
        to:
        $weekperiod = $weekday.' - '.$endweekday;

        Show
        Charles Kelly added a comment - Note it's not a "theme" problem. This is how I fixed it on my local copy of Moodle 1.8 This is the file that I changed: course/format/weeks/format.php I changed line 214 from: $weekperiod = $weekday.' '.$endweekday; to: $weekperiod = $weekday.' - '.$endweekday;
        Hide
        Stuart Anderson added a comment -

        Indeed, not a theme problem, but is inconsistent with previous versions of moodle and looks slightly odd. This should be a very minor change therefore should be fixed easily by Moodle.org.

        Show
        Stuart Anderson added a comment - Indeed, not a theme problem, but is inconsistent with previous versions of moodle and looks slightly odd. This should be a very minor change therefore should be fixed easily by Moodle.org.
        Hide
        Dan Poltawski added a comment -

        Hi, thanks for the report! I've fixed this in CVS.

        Show
        Dan Poltawski added a comment - Hi, thanks for the report! I've fixed this in CVS.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: