Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.8, 2.2.1
    • Fix Version/s: 2.1.7, 2.2.4, 2.3.1
    • Component/s: Authentication
    • Labels:
    • Environment:
      Server: MacPro, MacOS 10.4.9, Moodle 1.8 (downloaded 07 04 02), Apache 1.3.33, php 5.2.1, MySQL 5.0.24a
      Client: MacOS 10.4.9, Browsers: Firefox 2.0.0.2, Mozilla 1.7.5, Safari 2.0.4
    • Rank:
      6950

      Description

      On the login page (/login/index.php), there are usually instructions for new users to the right of the username and password login form. In moodle 1.6 there was a default set of instructions for each authentication method and for most languages - in my case, English and Japanese - so that whenever the authentication method and or the language was changed I did not have to rewrite the instructions.

      However, in 1.8 it seems that these default instructions are missing, or at least not accessible via the GUI. So, for example, when switching from "Email-based authentication" (my default) to "No authentication" (for demonstrations etc.) I have to rewrite the instructions in the 'Instructions (auth_instructions)' field in /admin/auth.php. This also means that the instructions can only be seen in one language. In the past, had a user selected to view moodle in Japanese, they would have seen the Japanese instructions relevant to the authentication process.

      Certainly, this is not a big issue, but it's rather annoying for admins to have to be rewriting instructions all the time - and rewriting will of course will not take care of the language problem.

        Activity

        Hide
        Petr Škoda added a comment -

        Hi!

        the right pane is for signup instructions (email or none auth) or custom instructions. Language switching works fine for me on the login page (tested ja, en, de and cs) - works on moodle.org too.

        Custom instructions are supplied by administrator and are stored in $CFG->auth_instructions, multilang content is allowed there.

        skodak

        Show
        Petr Škoda added a comment - Hi! the right pane is for signup instructions (email or none auth) or custom instructions. Language switching works fine for me on the login page (tested ja, en, de and cs) - works on moodle.org too. Custom instructions are supplied by administrator and are stored in $CFG->auth_instructions, multilang content is allowed there. skodak
        Hide
        Peter Ruthven-Stuart added a comment -

        Hello Petr

        OK - Understood. Problem solved.

        My confusion was caused by the fact that below the Instructions field in /admin/auth.php there is the following text:

        "Here you can provide instructions for your users, so they know which username and password they should be using. The text you enter here will appear on the login page. If you leave this blank then no instructions will be printed."

        In other words, if there is no text added here, there will be no instructions - which I now know is not true.

        My suggestion is that this explanation should be changed to read something like:

        "This field can be left blank. There are already default instructions which explain to users and potential users how to login. These instructions are in most languages, and are specific to each authentication method. If you want to have just one set of instructions, regardless of language and authentication method, you should type in your instructions here."

        Also, perhaps there should be an explanation on the /admin/auth.php page about how to change the wording of the default instructions.

        Thanks for your help.

        Show
        Peter Ruthven-Stuart added a comment - Hello Petr OK - Understood. Problem solved. My confusion was caused by the fact that below the Instructions field in /admin/auth.php there is the following text: "Here you can provide instructions for your users, so they know which username and password they should be using. The text you enter here will appear on the login page. If you leave this blank then no instructions will be printed." In other words, if there is no text added here, there will be no instructions - which I now know is not true. My suggestion is that this explanation should be changed to read something like: "This field can be left blank. There are already default instructions which explain to users and potential users how to login. These instructions are in most languages, and are specific to each authentication method. If you want to have just one set of instructions, regardless of language and authentication method, you should type in your instructions here." Also, perhaps there should be an explanation on the /admin/auth.php page about how to change the wording of the default instructions. Thanks for your help.
        Hide
        Petr Škoda added a comment -

        reopening, thanks

        Show
        Petr Škoda added a comment - reopening, thanks
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d;

        lqjjLKA0p6

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
        Hide
        Helen Foster added a comment -

        Adding 2.2.1 as affected version as this issue remains valid.

        Show
        Helen Foster added a comment - Adding 2.2.1 as affected version as this issue remains valid.
        Hide
        Dan Poltawski added a comment -

        Hi Helen,

        Do you agree that the text should be changed to:
        "This field can be left blank. There are already default instructions which explain to users and potential users how to login. These instructions are in most languages, and are specific to each authentication method. If you want to have just one set of instructions, regardless of language and authentication method, you should type in your instructions here."
        ?

        Show
        Dan Poltawski added a comment - Hi Helen, Do you agree that the text should be changed to: "This field can be left blank. There are already default instructions which explain to users and potential users how to login. These instructions are in most languages, and are specific to each authentication method. If you want to have just one set of instructions, regardless of language and authentication method, you should type in your instructions here." ?
        Hide
        Helen Foster added a comment -

        Hi Dan, my suggestion for the lang string is:

        Leave this blank for the default login instructions to be displayed on the login page. If you want to provide custom login instructions, enter them here.

        i.e. short and in the same style as other lang strings on the page, thinking better to leave a longer explanation for the docs.

        Thus, I have edited the documentation page linked to admin/auth.php and added screenshots and information on changing the default login instructions using the language customization feature for sites using more than one language:

        http://docs.moodle.org/en/admin/setting/manageauths

        I have also updated the FAQ: http://docs.moodle.org/22/en/Authentication_FAQ#How_can_I_change_the_.22Is_this_your_first_time_here.3F.22_instructions.3F

        Show
        Helen Foster added a comment - Hi Dan, my suggestion for the lang string is: Leave this blank for the default login instructions to be displayed on the login page. If you want to provide custom login instructions, enter them here. i.e. short and in the same style as other lang strings on the page, thinking better to leave a longer explanation for the docs. Thus, I have edited the documentation page linked to admin/auth.php and added screenshots and information on changing the default login instructions using the language customization feature for sites using more than one language: http://docs.moodle.org/en/admin/setting/manageauths I have also updated the FAQ: http://docs.moodle.org/22/en/Authentication_FAQ#How_can_I_change_the_.22Is_this_your_first_time_here.3F.22_instructions.3F
        Hide
        Dan Poltawski added a comment -

        Thanks Helen. I'm submitting the change for integration.

        TO INTEGRATOR: can be cherry-picked to 22 and 23

        Show
        Dan Poltawski added a comment - Thanks Helen. I'm submitting the change for integration. TO INTEGRATOR: can be cherry-picked to 22 and 23
        Hide
        Sam Hemelryk added a comment -

        Thanks guys, this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks guys, this has been integrated now
        Hide
        Sam Hemelryk added a comment -

        Passed thanks

        Show
        Sam Hemelryk added a comment - Passed thanks
        Hide
        Sam Hemelryk added a comment -

        Congratulations your code is upstream - gold star for you!

        This issue + 79 others made it in in time for the minor releases.
        Thank you everyone involved for your exuberant efforts.

        Show
        Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: