Moodle
  1. Moodle
  2. MDL-9285

Make the user profile fields appear on the user profile

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8.1
    • Component/s: Administration
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE
    • Rank:
      29600

      Description

      The new user profile fields do not actually show on the user profile! :-o

      Can you please pretty please make them do so?

        Activity

        Hide
        Shane Elliott added a comment -

        Hmmmm ... the rehacked profile class is centered around providing data for the moodleform class ie making the "edit profile" page work. Not trivial to do this anymore

        Show
        Shane Elliott added a comment - Hmmmm ... the rehacked profile class is centered around providing data for the moodleform class ie making the "edit profile" page work. Not trivial to do this anymore
        Hide
        Martin Dougiamas added a comment -

        I'll pass this to Petr, he's very keen on it.

        Show
        Martin Dougiamas added a comment - I'll pass this to Petr, he's very keen on it.
        Hide
        Martin Dougiamas added a comment -

        Hi Petr, a question about the rewrite you did:

        Menu items are now storing the value as an index NUMBER instead of the TEXT... this means if the menu is changed to add/remove items then all the user profiles will be wrong. I'd specifically asked Shane to store the text for these (like the Database module does) ... was this a deliberate change?

        Show
        Martin Dougiamas added a comment - Hi Petr, a question about the rewrite you did: Menu items are now storing the value as an index NUMBER instead of the TEXT... this means if the menu is changed to add/remove items then all the user profiles will be wrong. I'd specifically asked Shane to store the text for these (like the Database module does) ... was this a deliberate change?
        Hide
        Petr Škoda added a comment -

        It was not deliberate, should I change it (with needed upgrade code) in 1.8.1 or 1.9?

        Show
        Petr Škoda added a comment - It was not deliberate, should I change it (with needed upgrade code) in 1.8.1 or 1.9?
        Hide
        Martin Dougiamas added a comment -

        Thanks Petr.

        That's OK. Shane's got time to do this soon so I'll pass it back. He also wants to combine the two classes (define.class.php and field.class.php) back into one class file with different methods (instead of adding a 3rd class). Let us know if you can see any problem with that! Cheers

        Show
        Martin Dougiamas added a comment - Thanks Petr. That's OK. Shane's got time to do this soon so I'll pass it back. He also wants to combine the two classes (define.class.php and field.class.php) back into one class file with different methods (instead of adding a 3rd class). Let us know if you can see any problem with that! Cheers
        Hide
        Petr Škoda added a comment -

        Please, please, please - do not merge field and define classes. Mixing two different concepts into one class produces IMO hard to read and maintain code - it was a really hard time when studying the original merged classes. What benefits would it have to merge these two classes?

        It would not be a problem to store the two classes in one file, but I believe that we should keep them separate.

        Show
        Petr Škoda added a comment - Please, please, please - do not merge field and define classes. Mixing two different concepts into one class produces IMO hard to read and maintain code - it was a really hard time when studying the original merged classes. What benefits would it have to merge these two classes? It would not be a problem to store the two classes in one file, but I believe that we should keep them separate.
        Hide
        Shane Elliott added a comment -

        Kind of subjective I think as I had a really hard time reading the new code! Maybe it was the late night and the wine ....

        To keep it consistent with the database module fields, let's keep the define class and profile class separate and I rework the profile class to handle display better. (Database module fields have the field class for add/edit/display, and mod.html for define)

        Show
        Shane Elliott added a comment - Kind of subjective I think as I had a really hard time reading the new code! Maybe it was the late night and the wine .... To keep it consistent with the database module fields, let's keep the define class and profile class separate and I rework the profile class to handle display better. (Database module fields have the field class for add/edit/display, and mod.html for define)
        Hide
        Petr Škoda added a comment -

        Thanks, Shane. It may be subjective
        I guess the main difficulty may be in understanding of the new formslib, I hope we can keep similar coding style across all forms in Moodle.

        Show
        Petr Škoda added a comment - Thanks, Shane. It may be subjective I guess the main difficulty may be in understanding of the new formslib, I hope we can keep similar coding style across all forms in Moodle.
        Hide
        Petr Škoda added a comment -

        Offtopic: Are you planning to migrate the current fields from user table to profiles in 1.9?

        Show
        Petr Škoda added a comment - Offtopic: Are you planning to migrate the current fields from user table to profiles in 1.9?
        Hide
        Shane Elliott added a comment -

        That was the plan. The "idnumber" field was remaining in the user table and all the other optional fields were to be moved.
        However we need to sort out the backup and restore bit first. I had briefly spoken to Eloy about it but didn't have time to get anything done for 1.8

        Show
        Shane Elliott added a comment - That was the plan. The "idnumber" field was remaining in the user table and all the other optional fields were to be moved. However we need to sort out the backup and restore bit first. I had briefly spoken to Eloy about it but didn't have time to get anything done for 1.8
        Hide
        Shane Elliott added a comment -

        Changes submitted to 1.8 and HEAD.

        Show
        Shane Elliott added a comment - Changes submitted to 1.8 and HEAD.
        Hide
        Martin Dougiamas added a comment -

        YAY! Works great! (dance)

        Show
        Martin Dougiamas added a comment - YAY! Works great! (dance)
        Hide
        Akash Kumar added a comment - - edited

        The new fields are not visible in the user registration page as documented here: http://docs.moodle.org/en/Development:Customisable_user_profiles

        Shane, i hope you will fix this soon. TIA.

        Show
        Akash Kumar added a comment - - edited The new fields are not visible in the user registration page as documented here: http://docs.moodle.org/en/Development:Customisable_user_profiles Shane, i hope you will fix this soon. TIA.
        Hide
        Shane Elliott added a comment -

        Have added a new issue to keep track of progress on this. While the original idea was to have the required custom fields in the signup page there is some argument against including them.

        See: MDL-9702

        Show
        Shane Elliott added a comment - Have added a new issue to keep track of progress on this. While the original idea was to have the required custom fields in the signup page there is some argument against including them. See: MDL-9702

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: