Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-9295

PARAM_URL/PARAM_LOCALURL does not accept http://localhost/ or other hosts on intranets

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8.4, 1.9
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      Judging from inline comments this is a know issue:

      // PARAM_URL requires a genuine TLD (I think) This breaks my testing
      $temp_wwwroot = clean_param($form->wwwroot, PARAM_URL);
      if ($temp_wwwroot !== $form->wwwroot)

      { trigger_error("We now parse the wwwroot with PARAM_URL. Your URL will need to have a valid TLD, etc."); error(get_string("invalidurl", 'mnet'),'peers.php'); exit; }

      unset($temp_wwwroot);

      I do not think that we need to clean the url that is submitted by amin, because mnet should be IMHO usable in intranets that are using compaly.local or company.lan domains too.

        Attachments

          Issue Links

          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-9955 would be nice if PARAM_URL let through urls with localhost in them for those of us developing on a local server.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-11880 Running on localhost, when you create a question from the quiz editing screen, you end up on the question bank screen

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              skodak Petr Skoda
              Tester:
              Nobody
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jan/08