Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-9295

PARAM_URL/PARAM_LOCALURL does not accept http://localhost/ or other hosts on intranets

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.8
    • 1.8.4, 1.9
    • Libraries
    • None
    • MOODLE_18_STABLE
    • MOODLE_18_STABLE, MOODLE_19_STABLE

    Description

      Judging from inline comments this is a know issue:

      // PARAM_URL requires a genuine TLD (I think) This breaks my testing
      $temp_wwwroot = clean_param($form->wwwroot, PARAM_URL);
      if ($temp_wwwroot !== $form->wwwroot)

      { trigger_error("We now parse the wwwroot with PARAM_URL. Your URL will need to have a valid TLD, etc."); error(get_string("invalidurl", 'mnet'),'peers.php'); exit; }

      unset($temp_wwwroot);

      I do not think that we need to clean the url that is submitted by amin, because mnet should be IMHO usable in intranets that are using compaly.local or company.lan domains too.

      Attachments

        Issue Links

          Activity

            People

              timhunt Tim Hunt
              skodak Petr Skoda
              Nobody Nobody
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/Jan/08